Updated Help Hub for ET. #3741
Merged
Updated Help Hub for ET. #3741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ak/ET-2376_Help_Hub
Replaced static resource sections setup with the dynamic `Section_Builder` for easier scalability and maintenance. Implemented new filters and descriptions to improve customizability and consistency in Help Hub content.
tec-bot
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
phpcs
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
[phpcs] reported by reviewdog 🐶PEAR.Functions.FunctionCallSignature.SpaceAfterOpenBracket
Expected 1 spaces after opening parenthesis; 0 found
[phpcs] reported by reviewdog 🐶PEAR.Functions.FunctionCallSignature.SpaceBeforeCloseBracket
Expected 1 spaces before closing parenthesis; 0 found
[phpcs] reported by reviewdog 🐶Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed
Tabs must be used to indent lines; spaces are not allowed
Replaced the generic Section_Builder with Link_Section_Builder and FAQ_Section_Builder for better modularity and maintainability. Updated functions to individually define sections, improving clarity and extensibility of the resource data. Addressed minor formatting inconsistencies in some Help Hub descriptions.
Streamlined Help Hub initialization by introducing `initialize()` to prevent redundant setup. Added customization hooks for header logo and Help Hub pages. Removed unused `Resource_Data_Mock.php` and updated tests to validate the changes.
Updated the filter name and parameter from "support_title" to "support_description" for consistency and accurate labeling. Adjusted associated comments and return descriptions to align with the changes.
- Correct text domain reference for "support description."
…ak/ET-2376_Help_Hub
- Implement `redirect_to_help_hub` to redirect users from the old Help page to the new Help Hub.
- Add new `et_icon` for Event Tickets logo. - Replace `tec_icon` with `et_icon` in Help Hub link.
Camwyn
approved these changes
Apr 29, 2025
rafsuntaskin
previously requested changes
Apr 29, 2025
…ta`. - **Update PHP docblocks**: Add missing @SInCE tags and improve parameter/return annotations. - **Introduce integration tests** for Help Hub templates and functionality. - **Add snapshot testing** for template rendering.
Co-authored-by: Rafsun Chowdhury <[email protected]>
Camwyn
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
🗒️ Description
🎥 Artifacts
✔️ Checklist
npm run changelogto add changelog file(s). More info herewpunitorintegrationtests.wpunitorintegrationtests.