feat: expose Response Headers#15
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR exposes HTTP response headers to library consumers by adding a Headers field to the Response struct and populating it with the HTTP response headers.
- Added a Headers field to the Response struct to store HTTP response headers
- Populated the Headers field with response headers from the HTTP response
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| response.go | Added Headers field to Response struct to store HTTP response headers |
| request.go | Populated Headers field with HTTP response headers from the HTTP response |
Comments suppressed due to low confidence (1)
response.go:24
- [nitpick] The field name 'Headers' should follow Go naming conventions and be 'HTTPHeaders' or 'ResponseHeaders' to be more descriptive, as 'Headers' could be ambiguous about whether these are request or response headers.
Headers map[string][]string // The HTTP Response headers
e7d47ae to
8a32382
Compare
8a32382 to
c3f7317
Compare
nicola-strappazzon
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to Expose the Response Headers to the consumers of the library.