Skip to content

feat: expose Response Headers#15

Merged
esroyo merged 1 commit into
mainfrom
feat/NO-ISSUE_expose-response-headers
Jul 25, 2025
Merged

feat: expose Response Headers#15
esroyo merged 1 commit into
mainfrom
feat/NO-ISSUE_expose-response-headers

Conversation

@esroyo

@esroyo esroyo commented Jul 25, 2025

Copy link
Copy Markdown
Member

We need to Expose the Response Headers to the consumers of the library.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR exposes HTTP response headers to library consumers by adding a Headers field to the Response struct and populating it with the HTTP response headers.

  • Added a Headers field to the Response struct to store HTTP response headers
  • Populated the Headers field with response headers from the HTTP response

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
response.go Added Headers field to Response struct to store HTTP response headers
request.go Populated Headers field with HTTP response headers from the HTTP response
Comments suppressed due to low confidence (1)

response.go:24

  • [nitpick] The field name 'Headers' should follow Go naming conventions and be 'HTTPHeaders' or 'ResponseHeaders' to be more descriptive, as 'Headers' could be ambiguous about whether these are request or response headers.
	Headers                map[string][]string // The HTTP Response headers

Comment thread response.go Outdated
@esroyo esroyo force-pushed the feat/NO-ISSUE_expose-response-headers branch 2 times, most recently from e7d47ae to 8a32382 Compare July 25, 2025 13:41
@esroyo esroyo force-pushed the feat/NO-ISSUE_expose-response-headers branch from 8a32382 to c3f7317 Compare July 25, 2025 13:59
@esroyo esroyo merged commit 1f66e89 into main Jul 25, 2025
1 check passed
@aherrera-thn aherrera-thn deleted the feat/NO-ISSUE_expose-response-headers branch October 1, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants