Updating files so they will compile with clang #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum necessary version of C++ had to be bumped to C++17 to avoid any warning message. Additionally, clang is more opinionated on how and when to use `constexpr`. Static memeber variables can be declared with `constexpr` keyword, however, if the initialization of that variable is from a function that is not `constexpr`, such as `std::pow` (at least until C++26) clang will complain. So these static initializations need to be moved out of line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum necessary version of C++ had to be bumped to C++17 to avoid any warning message. Additionally, clang is more opinionated on how and when to use
constexpr. Static memeber variables can be declared withconstexprkeyword, however, if the initialization of that variable is from a function that is notconstexpr, such asstd::pow(at least until C++26) clang will complain.So these static initializations need to be moved out of line.
Note that the compiler tested was clang 14.0