Skip to content

Support crypto (AKA eay) with MSVC as well #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sgeto
Copy link
Contributor

@sgeto sgeto commented May 21, 2018

No description provided.

@sgeto
Copy link
Contributor Author

sgeto commented May 21, 2018

@gvanem
Copy link
Contributor

gvanem commented May 21, 2018

Where does c:\Win32-OpenSSL and the ancient libeay32.dll come from? A built-in in AppVeyor? The OpenSSL DLLs have been called libcrypto.dll and libssl.dll for quite some time now.

@sgeto
Copy link
Contributor Author

sgeto commented May 22, 2018

It's one of these http://www.slproweb.com/products/Win32OpenSSL.html
And it's very recent (probable OpenSSL-1.0.2o or so).

I don't know why OpenSSL's VC++ libs have a different name. I always thought that naming scheme is like windump vs. tcpdump.
And when I follow OpenSSL building instructions for MSVC (in INSTALL.W32) the libs it spits out are these.

@gvanem
Copy link
Contributor

gvanem commented May 22, 2018

That was changed in April-2017 (?). If I do a:

perl Configure VC-WIN32 --prefix=%cd
nmake

on current master, I get these:

.\libssl-1_1.dll
.\libcrypto-1_1.dll
.\libcrypto.lib
.\libssl.lib

@sgeto
Copy link
Contributor Author

sgeto commented May 23, 2018

um, simply nmake after configure?
And that works?

According to INSTALL.W32, you should do a nmake -f ms\ntdll.mak.
The versioning is different too. I get 1.0.2X and you have 1.1.0X.
Not sure really...

@mcr
Copy link
Member

mcr commented May 3, 2019

Rebase? Can we be sure that we are building against an openssl that itself is the current release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants