Implementation of IPv4 Extended Echo Request/Response

[nickludwig]

As specified in RFC 8337, an implementation of the IPv4 Extended Echo Request and Response within the print-icmp.c file. The included .pcap file is titled icmp-ext-ipv4.pcap

Link to RFC: https://tools.ietf.org/html/rfc8335#section-2.1
Link to Wireshark implementation, where I found and used the example ipv4 pcap file: https://gitlab.com/wireshark/wireshark/-/issues/14457

[infrastation]

Thank you for suggesting this improvement. This pull request has 9 "work in progress" commits, is this the right branch?

[infrastation]

Obviously, the CI builds did not pass because of the compiler warnings, please run touch .devel && ./configure && make clean && make -s all (item 4 in CONTRIBUTING) to see them locally and to fix them.

[nickludwig]

Ah, yes. My bad. I'll fix the WIP commits/the CI builds and get back to you in the next few days.

…

On Sun, Oct 11, 2020 at 3:08 PM Denis Ovsienko ***@***.***> wrote: Obviously, the CI builds did not pass because of the compiler warnings, please run touch .devel && ./configure && make clean && make -s all (item 4 in CONTRIBUTING) to see them locally and to fix them. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#883 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMIBK5XPGKG5EQDPGJK5AFTSKIUHNANCNFSM4SL7557A> .

[nickludwig]

Fixed the previous issues.

[infrastation]

Thank you. Please do not include configure in this case even if it is slightly different, also please find a good place in tests/TESTLIST and follow items 6 and 7 of CONTRIBUTING as closely as possible to amend the proposed commit.

[fxlb]

configure file removed => some builds broken.

[nickludwig]

Thanks! Should be fixed now.

[nickludwig]

@infrastation, I followed all of the CONTRIBUTING guidelines and think it's ready to go. Please let me know if there is anything else that I can help with.

[fxlb]

As specified in RFC 8337, an implementation of the IPv4 Extended [...]
(also in the commit message)

Or RFC 8335?

[fxlb]

First look, prior to further review.

1. Need a rebase on top of [the-tcpdump-group:master] (not a merge, to keep a readable history).
2. 'switch (icmp_code)' could be replaced by a 'struct tok' and a tok2str() call.
3. 'switch (reply_state & STATE_MASK)': same.
4. Fix typo: uses of RFC 8337 instead of RFC 8335 (Conversation and commit message)
   (Implementation of IPv4 Extended Echo Request/Response #883 (comment))
5. Remove trailing spaces and tabs.
6. Check [ ] "Allow edits from maintainers" may help.