Skip to content

fix: update fork warn workflow#34

Merged
sgibson91 merged 5 commits intothe-turing-way:mainfrom
sgibson91:fix-fork-warn-workflow
Apr 9, 2026
Merged

fix: update fork warn workflow#34
sgibson91 merged 5 commits intothe-turing-way:mainfrom
sgibson91:fix-fork-warn-workflow

Conversation

@sgibson91
Copy link
Copy Markdown
Member

@sgibson91 sgibson91 commented Mar 27, 2026

fork-warn workflow:

  • Use a more descriptive filename
  • Update if condition to check the name of the head repo in PRs
  • Use pull_request_target event type so workflow can access GITHUB_TOKEN to make the comment
  • Trigger workflow on opened and reopened PRs

plan-apply workflow:

  • Isolate its secrets into an environment
  • Ensure jobs don't run simultaneously to avoid state lock

@sgibson91 sgibson91 requested review from a team as code owners March 27, 2026 19:08
@sgibson91 sgibson91 marked this pull request as draft March 27, 2026 19:14
@sgibson91 sgibson91 moved this from To Be Refined to In progress in Infrastructure Working Group Mar 31, 2026
@sgibson91 sgibson91 closed this Apr 1, 2026
@github-project-automation github-project-automation Bot moved this from In progress to Done in Infrastructure Working Group Apr 1, 2026
@sgibson91 sgibson91 reopened this Apr 1, 2026
@sgibson91 sgibson91 closed this Apr 1, 2026
@sgibson91 sgibson91 reopened this Apr 1, 2026
@sgibson91 sgibson91 moved this from Done to In progress in Infrastructure Working Group Apr 1, 2026
@sgibson91 sgibson91 marked this pull request as ready for review April 1, 2026 13:45
@sgibson91 sgibson91 moved this from In progress to In review in Infrastructure Working Group Apr 1, 2026
@sgibson91
Copy link
Copy Markdown
Member Author

@the-turing-way/infrastructure-working-group ready for review. We may have to bypass rules to allow this to be merged since I made the PR from a fork.

sgibson91 and others added 5 commits April 2, 2026 08:48
- Use a more descriptive filename
- Update if condition to check the name of the head repo in PRs
ensure this job can access GITHUB_TOKEN when running from a fork
Copy link
Copy Markdown
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a warning in this PR. Is that because it didn't have access to the token?

@sgibson91
Copy link
Copy Markdown
Member Author

sgibson91 commented Apr 3, 2026

It's because the workflow failed when I opened the PR because it didn't have access to the token. Also because the reopened type isn't on main yet, that won't trigger it again.

I limited when the workflow would run so I wouldn't have to write logic along the lines of "does a comment from this workflow already exist?" in order to limit the number of comments made.

@sgibson91 sgibson91 merged commit 1eed9e3 into the-turing-way:main Apr 9, 2026
16 of 17 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in Infrastructure Working Group Apr 9, 2026
@sgibson91 sgibson91 deleted the fix-fork-warn-workflow branch April 9, 2026 08:10
@sgibson91
Copy link
Copy Markdown
Member Author

It worked! #38 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants