Fix : Pinterest share link using wrong description and media#907
Closed
NITHINSPACETIME wants to merge 2 commits intotheNewDynamic:mainfrom
Closed
Fix : Pinterest share link using wrong description and media#907NITHINSPACETIME wants to merge 2 commits intotheNewDynamic:mainfrom
NITHINSPACETIME wants to merge 2 commits intotheNewDynamic:mainfrom
Conversation
Fixes theNewDynamic#812 - Added 'featured_image' value type support in getShareLink.html partial - Uses existing GetFeaturedImage.html partial to get image URL - Updated Pinterest particles config to use correct mappings: - description: title (was: summary) - media: featured_image (was: permalink)
Collaborator
|
Thank you. Please break that into two PRs. One that implements |
Contributor
Author
Sure, I'll split this into two PRs. Will update shortly... |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #812
Hey, I noticed the Pinterest share link was broken - it was using the page summary (super long text) for the description and the page URL for the media parameter instead of the actual image.
What was happening:
description→ page summary (way too verbose, sometimes causes errors)media→ just the page permalink (not an image at all)The fix:
featured_imagein the share link builderTested locally and the share links look correct now.