Skip to content

Fix: Use 2025 Italy GP session to show legacy line in docs#856

Open
TracingInsights wants to merge 2 commits into
theOehrly:mainfrom
TracingInsights:master
Open

Fix: Use 2025 Italy GP session to show legacy line in docs#856
TracingInsights wants to merge 2 commits into
theOehrly:mainfrom
TracingInsights:master

Conversation

@TracingInsights

Copy link
Copy Markdown
Contributor

No description provided.

Updated session year and lap number for plotting.
@theOehrly

Copy link
Copy Markdown
Owner

Is the main reason for this just to use a more recent season or is there something else?

@TracingInsights

Copy link
Copy Markdown
Contributor Author
image

legacy line is missing from the chart in docs at https://docs.fastf1.dev/api_reference/legacy/legacy.html

@theOehrly

Copy link
Copy Markdown
Owner

Sorry for the delay. I had wanted to look at this in more detail and then I forgot about your PR instead 😅

I was wondering what caused this problem in the first place. Why did this change at some point? I did look at this a bit more just now. And so far I haven't been able to figure out what's going wrong.
Now, applying your change, both lines are shown again. But they are very different to the point where at least one of them has to be very wrong. So I don't really want to merge this right now. I assume that the newer implementation is more correct, since I wrote it for that reason. And maybe it's just time to get rid of the legacy method. I don't want to spend time fixing it and if it's very wrong, it should go.

But I'd still like to figure out what's the problem here. Therefore, I'll leave this open for now and I'll plan to look at this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants