Add TeamId and DriverId to F1 API driver info for FP sessions (fix #811)#923
Open
TumCucTom wants to merge 1 commit into
Open
Add TeamId and DriverId to F1 API driver info for FP sessions (fix #811)#923TumCucTom wants to merge 1 commit into
TumCucTom wants to merge 1 commit into
Conversation
The F1 API provides TeamId and DriverId for drivers, but _drivers_from_f1_api was not collecting these fields. For FP sessions where Ergast data is not available (only race session data is used from Ergast), these fields would be missing entirely. This adds TeamId and DriverId to the F1 API driver info mapping so that FP session results include these fields. Fixes theOehrly#811 Co-Authored-By: Zippy AI <tomkinsbale@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The F1 API provides TeamId and DriverId for drivers, but
_drivers_from_f1_apiwas not collecting these fields. For FP sessions where Ergast data is not available (only race session data is used from Ergast for practice sessions), these fields would be missing entirely.This adds TeamId and DriverId to the F1 API driver info mapping so that FP session results include these fields.
Fix
Added
TeamIdandDriverIdto the field mapping in_drivers_from_f1_api().Testing
Unable to test locally due to data fetching requirements. The fix follows the existing pattern in the code for other fields from the F1 API.
Checklist
AI Disclosure
AI was used as a coding assistant. The human author reviewed all AI-generated code and changes.