Skip to content

Conversation

@fdintino
Copy link
Member

@fdintino fdintino commented Jun 1, 2025

No description provided.

@fdintino fdintino force-pushed the drop-python-2-thumbor-6 branch from 218053d to 91baebc Compare June 1, 2025 18:48
@github-actions
Copy link

github-actions bot commented Jun 1, 2025

Unit Test Results

    6 files  ± 0      6 suites  ±0   2m 32s ⏱️ -18s
  175 tests  - 12    175 ✅  - 12   0 💤 ± 0  0 ❌ ±0 
1 050 runs   - 58  1 036 ✅  - 10  14 💤  - 48  0 ❌ ±0 

Results for commit 8f71c6d. ± Comparison against base commit 507ecac.

This pull request removes 12 tests.
tests.result_storages.test_s3_storage ‑ test_normalize_path_tc_aws_settings
tests.result_storages.test_s3_storage ‑ test_s3_result_storage_load[unsafe/hotdog.gif-image/gif-*/*-False]
tests.result_storages.test_s3_storage ‑ test_s3_result_storage_load[unsafe/hotdog.gif-image/gif-*/*-True]
tests.result_storages.test_s3_storage ‑ test_s3_result_storage_load[unsafe/hotdog.gif/mp4-video/mp4-video/*-False]
tests.result_storages.test_s3_storage ‑ test_s3_result_storage_load[unsafe/hotdog.gif/mp4-video/mp4-video/*-True]
tests.result_storages.test_s3_storage ‑ test_s3_result_storage_load[unsafe/hotdog.gif/webp-image/webp-image/webp-False]
tests.result_storages.test_s3_storage ‑ test_s3_result_storage_load[unsafe/hotdog.gif/webp-image/webp-image/webp-True]
tests.result_storages.test_s3_storage ‑ test_s3_result_storage_load[unsafe/hotdog.png-image/png-*/*-False]
tests.result_storages.test_s3_storage ‑ test_s3_result_storage_load[unsafe/hotdog.png-image/png-*/*-True]
tests.result_storages.test_s3_storage ‑ test_s3_result_storage_save[-image/gif]
…

♻️ This comment has been updated with latest results.

@fdintino fdintino force-pushed the drop-python-2-thumbor-6 branch from 91baebc to e419058 Compare June 1, 2025 18:53
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.80%. Comparing base (507ecac) to head (8f71c6d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   95.74%   93.80%   -1.95%     
==========================================
  Files          17       17              
  Lines         870      855      -15     
  Branches      180      144      -36     
==========================================
- Hits          833      802      -31     
- Misses         29       48      +19     
+ Partials        8        5       -3     
Files with missing lines Coverage Δ
src/thumbor_video_engine/app.py 100.00% <100.00%> (+16.98%) ⬆️
src/thumbor_video_engine/filters/format.py 100.00% <100.00%> (ø)
src/thumbor_video_engine/filters/lossless.py 100.00% <100.00%> (ø)
src/thumbor_video_engine/filters/still.py 100.00% <100.00%> (ø)
src/thumbor_video_engine/filters/tune.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507ecac...8f71c6d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fdintino fdintino force-pushed the drop-python-2-thumbor-6 branch from e419058 to 61158fb Compare June 1, 2025 18:59
@fdintino fdintino force-pushed the drop-python-2-thumbor-6 branch from 61158fb to 8f71c6d Compare June 2, 2025 00:34
@fdintino fdintino marked this pull request as ready for review June 2, 2025 12:24
@fdintino fdintino merged commit d8dc307 into main Jun 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants