Skip to content

Fb fix #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fb fix #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23364ba
fix(ios): unrecognized selector sent to instance when using props
habovh Oct 9, 2025
5b336e1
fix: update package.json and yarn.lock for project renaming and versi…
ron4ex Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions ios/RCTFBSDK/login/RCTFBSDKLoginButtonManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,23 +41,32 @@ - (UIView *)view

RCT_EXPORT_VIEW_PROPERTY(onChange, RCTBubblingEventBlock)

RCT_EXPORT_VIEW_PROPERTY(permissions, NSStringArray)
RCT_CUSTOM_VIEW_PROPERTY(permissions, NSStringArray, RCTFBSDKLoginButtonView)
{
[view.loginButton setPermissions:json ? json : nil];
}

RCT_EXPORT_VIEW_PROPERTY(defaultAudience, FBSDKDefaultAudience)
RCT_CUSTOM_VIEW_PROPERTY(defaultAudience, FBSDKDefaultAudience, RCTFBSDKLoginButtonView)
{
if (json)
{
[view.loginButton setDefaultAudience:[RCTConvert FBSDKDefaultAudience:json]];
}
}

RCT_CUSTOM_VIEW_PROPERTY(nonceIOS, NSString, FBSDKLoginButton)
RCT_CUSTOM_VIEW_PROPERTY(nonceIOS, NSString, RCTFBSDKLoginButtonView)
{
[view setNonce:json ? json : nil];
[view.loginButton setNonce:json ? json : nil];
}

RCT_CUSTOM_VIEW_PROPERTY(loginTrackingIOS, NSString, FBSDKLoginButton)
RCT_CUSTOM_VIEW_PROPERTY(loginTrackingIOS, NSString, RCTFBSDKLoginButtonView)
{
[view setLoginTracking:([json isEqualToString:@"limited"]) ? FBSDKLoginTrackingLimited : FBSDKLoginTrackingEnabled];
[view.loginButton setLoginTracking:([json isEqualToString:@"limited"]) ? FBSDKLoginTrackingLimited : FBSDKLoginTrackingEnabled];
}

RCT_CUSTOM_VIEW_PROPERTY(tooltipBehaviorIOS, FBSDKLoginButtonTooltipBehavior, FBSDKLoginButton)
RCT_CUSTOM_VIEW_PROPERTY(tooltipBehaviorIOS, FBSDKLoginButtonTooltipBehavior, RCTFBSDKLoginButtonView)
{
[view setTooltipBehavior:json ? [RCTConvert FBSDKLoginButtonTooltipBehavior:json] : FBSDKLoginButtonTooltipBehaviorAutomatic];
[view.loginButton setTooltipBehavior:json ? [RCTConvert FBSDKLoginButtonTooltipBehavior:json] : FBSDKLoginButtonTooltipBehaviorAutomatic];
}


Expand Down
2 changes: 2 additions & 0 deletions ios/RCTFBSDK/login/RCTFBSDKLoginButtonView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

@interface RCTFBSDKLoginButtonView: UIView<FBSDKLoginButtonDelegate>

@property (nonatomic, strong) FBSDKLoginButton *loginButton;

@property (nonatomic, copy) RCTBubblingEventBlock onChange;

@end
2 changes: 0 additions & 2 deletions ios/RCTFBSDK/login/RCTFBSDKLoginButtonView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

@interface RCTFBSDKLoginButtonView ()

@property (nonatomic, strong) FBSDKLoginButton *loginButton;

@end

@implementation RCTFBSDKLoginButtonView
Expand Down
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{
"name": "react-native-fbsdk-next",
"version": "13.4.1",
"description": "Facebook SDK support for React Native apps.",
"name": "@holy-gd/react-native-fbsdk-next",
"version": "13.4.2",
"description": "Facebook SDK support for React Native apps. (Custom build with Expo fixes)",
"main": "lib/commonjs/index.js",
"module": "lib/module/index.js",
"types": "lib/typescript/src/index.d.ts",
"sideEffects": false,
"author": {
"name": "Marcos Bérgamo"
"name": "Holy GD"
},
"contributors": [
{
Expand All @@ -34,9 +34,9 @@
],
"repository": {
"type": "git",
"url": "git+https://github.com/thebergamo/react-native-fbsdk-next.git"
"url": "git+https://github.com/holy-gd/react-native-fbsdk-next.git"
},
"homepage": "https://github.com/thebergamo/react-native-fbsdk-next/",
"homepage": "https://github.com/holy-gd/react-native-fbsdk-next#readme",
"keywords": [
"react",
"react-native",
Expand Down
86 changes: 43 additions & 43 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3654,6 +3654,49 @@ __metadata:
languageName: node
linkType: hard

"@holy-gd/react-native-fbsdk-next@workspace:.":
version: 0.0.0-use.local
resolution: "@holy-gd/react-native-fbsdk-next@workspace:."
dependencies:
"@babel/core": "npm:^7.24.0"
"@babel/runtime": "npm:^7.23.9"
"@react-native-community/eslint-config": "npm:^3.2.0"
"@semantic-release/commit-analyzer": "npm:^11.1.0"
"@semantic-release/git": "npm:^10.0.1"
"@semantic-release/github": "npm:^9.2.6"
"@semantic-release/npm": "npm:^11.0.2"
"@semantic-release/release-notes-generator": "npm:^12.1.0"
"@trivago/prettier-plugin-sort-imports": "npm:^4.3.0"
"@tsconfig/node14": "npm:^14.1.0"
"@types/react": "npm:^18.2.79"
"@types/xml2js": "npm:^0.4.14"
"@typescript-eslint/eslint-plugin": "npm:^6.19.1"
"@typescript-eslint/parser": "npm:^6.19.1"
babel-jest: "npm:^29.7.0"
babel-plugin-module-resolver: "npm:^5.0.0"
conventional-changelog-conventionalcommits: "npm:^7.0.2"
eslint: "npm:^8.56.0"
expo: "npm:^51.0.38"
expo-module-scripts: "npm:^3.4.0"
jest: "npm:^29.7.0"
metro-react-native-babel-preset: "npm:^0.77.0"
prettier: "npm:^3.2.4"
react: "npm:18.2.0"
react-native: "npm:^0.74.5"
react-native-builder-bob: "npm:^0.23.2"
react-test-renderer: "npm:18.2.0"
semantic-release: "npm:^23.0.0"
typescript: "npm:^5.3.3"
xml2js: "npm:^0.6.2"
peerDependencies:
expo: ">=47.0.0"
react-native: ">=0.63.3"
peerDependenciesMeta:
expo:
optional: true
languageName: unknown
linkType: soft

"@humanwhocodes/config-array@npm:^0.11.13":
version: 0.11.14
resolution: "@humanwhocodes/config-array@npm:0.11.14"
Expand Down Expand Up @@ -14908,49 +14951,6 @@ __metadata:
languageName: node
linkType: hard

"react-native-fbsdk-next@workspace:.":
version: 0.0.0-use.local
resolution: "react-native-fbsdk-next@workspace:."
dependencies:
"@babel/core": "npm:^7.24.0"
"@babel/runtime": "npm:^7.23.9"
"@react-native-community/eslint-config": "npm:^3.2.0"
"@semantic-release/commit-analyzer": "npm:^11.1.0"
"@semantic-release/git": "npm:^10.0.1"
"@semantic-release/github": "npm:^9.2.6"
"@semantic-release/npm": "npm:^11.0.2"
"@semantic-release/release-notes-generator": "npm:^12.1.0"
"@trivago/prettier-plugin-sort-imports": "npm:^4.3.0"
"@tsconfig/node14": "npm:^14.1.0"
"@types/react": "npm:^18.2.79"
"@types/xml2js": "npm:^0.4.14"
"@typescript-eslint/eslint-plugin": "npm:^6.19.1"
"@typescript-eslint/parser": "npm:^6.19.1"
babel-jest: "npm:^29.7.0"
babel-plugin-module-resolver: "npm:^5.0.0"
conventional-changelog-conventionalcommits: "npm:^7.0.2"
eslint: "npm:^8.56.0"
expo: "npm:^51.0.38"
expo-module-scripts: "npm:^3.4.0"
jest: "npm:^29.7.0"
metro-react-native-babel-preset: "npm:^0.77.0"
prettier: "npm:^3.2.4"
react: "npm:18.2.0"
react-native: "npm:^0.74.5"
react-native-builder-bob: "npm:^0.23.2"
react-test-renderer: "npm:18.2.0"
semantic-release: "npm:^23.0.0"
typescript: "npm:^5.3.3"
xml2js: "npm:^0.6.2"
peerDependencies:
expo: ">=47.0.0"
react-native: ">=0.63.3"
peerDependenciesMeta:
expo:
optional: true
languageName: unknown
linkType: soft

"react-native@npm:^0.74.5":
version: 0.74.6
resolution: "react-native@npm:0.74.6"
Expand Down
Loading