Add Input Validation to CLI Commands Based on Server Request Models - #17
Merged
Conversation
- Add validation utilities for Ethereum addresses, private keys, amounts, URLs, device IDs - Integrate validation into auth, stake, balance, LLM, federated learning, storage, and reputation commands - Add validation for task parameters, model names, prompts, dataset CIDs, and FL session parameters - Improve error handling with descriptive validation error messages - Add comprehensive test coverage for all validation functions
…learning.go and ethereum_service.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds comprehensive input validation to all CLI commands in the parity-client, ensuring that user inputs match the expected request body structures from the parity-server API.
Changes Made
New Validation Utilities (
internal/utils/validation.go)Enhanced CLI Commands
Error Handling
ValidationErrortype with field-specific error messagesBenefits