feat: restore beforeEach in test utils #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add back `beforeEach` to trigger the automatic mocking. - Keep the `beforeAll` hook - Add a check to `setupIntersectionMocking` method, so it only runs if mocking hasn't been set up - Introduce a `destroyIntersectionMocking` method to clear all mocking, and revert to the browser implementation
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
commit: |
|
🎉 This PR is included in version 9.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to
test-utils, to ensure mocking is configured in a reliable manner when using JestbeforeEachto trigger the automatic mocking. This was removed in Does not recognise Vitest 2 insidebeforeAllhook #689beforeAllhooksetupIntersectionMockingmethod, so it only runs if mocking hasn't been set updestroyIntersectionMockingmethod to clear all mocking, and revert to the browser implementationCloses #699