Skip to content

fix(packages/config,packages/ui): render all accepted social icons #157

Description

@zrosenbauer

Summary

Social links accept icon configuration that the UI cannot render consistently. Unknown string values fall back to a generic link, while valid { svg } values are dropped before rendering.

Reproduction

socials: [
  { icon: 'slack', url: 'https://app.slack.com' },
  { icon: 'logos:google-gmail', url: 'https://mail.google.com' },
  { icon: { svg: '<svg>...</svg>' }, url: 'https://drive.google.com' },
]

The named slug renders, the Iconify ID becomes a generic link, and the inline SVG entry disappears.

Expected behavior

Every icon shape accepted by config validation must have a defined rendering path. Named social slugs should keep their curated pixel icons; valid Iconify IDs and inline SVG values should use the shared icon renderer.

Acceptance criteria

  • Named social slugs retain their current mapped icons.
  • Valid Iconify IDs render directly.
  • { svg } icons either render safely or are removed from the public schema in a deliberate breaking change.
  • Invalid values produce validation feedback instead of silent fallback or omission.
  • Tests cover all accepted icon forms and inaccessible/malformed values.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions