Adding a new feature "Dark Mode" #851
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's another pull request for the dark mode, see my comment here: #838. Your dark mode version has similar visual inconsistencies. If I merge any of these two pull requests, it'll be the one that looks proper and nice. |
|
Closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done:
Implemented a dark mode feature that allows users to switch between light and dark themes.
Added a toggle button in the UI for theme selection.
Updated styles to adjust background colors, text colors,
and other UI elements for dark mode.
Ensured that the theme preference is saved using local storage to persist user settings.
How it was implemented:
Introduced a theme switcher component.
Applied CSS variables and conditional class changes to manage light/dark modes.
Used local storage to remember the user's preferred theme across sessions.