-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
πͺ Windows Canary: combined build/test of all open Windows fixes #2699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thedotmack
wants to merge
35
commits into
main
Choose a base branch
from
windows-canary
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
70ed207
fix: restore Windows spawn fix from PR #751 + add Windows CI
thedotmack 8d20c7c
fix(ci): Windows workflow β install without lockfile (project uses Bun)
thedotmack 3b91d84
fix(ci+windows): quote bun-runner shell:true args; replace dynamic smβ¦
thedotmack e65c0c9
ci(windows): drop static-grep tripwires, keep real Windows build
thedotmack a2c4119
fix(chroma): drop cmd.exe wrap on Windows uvx spawn (2426)
ousamabenyounes eb6344a
fix(windows): add PowerShell call operator (&) to hook commands
sabinss4 979f0dd
fix(chroma): escape cmd.exe metacharacters in uvx args on Windows
YOMXXX d532723
docs: regenerate CHANGELOG for v13.3.0
thedotmack 8080499
fix(mcp): replace sh launcher with cross-platform node -e (closes #2461)
YOMXXX 36eb701
fix(chroma): also escape `%` on Windows to prevent cmd.exe env expansion
YOMXXX 0fcbbf1
fix(mcp): forward signals + preserve signal-death exit code
YOMXXX 6a1a810
fix(hooks): replace fragile $SHELL -lc PATH probe with printenv-firstβ¦
YOMXXX 6e887ec
fix(supervisor): make Windows captureProcessStartToken actually returβ¦
YOMXXX b7a143e
fix(supervisor): also guard result.error in spawnSync token capture (β¦
YOMXXX 917db26
fix(mcp): launch mcp-search via node so Windows can spawn it
CaTeIM b55a9ef
fix(windows): strip BOM from settings.json + exempt lifecycle subcommβ¦
henrygcosta 69c46e7
fix: suppress printf write errors when pipe breaks in inline bash hooks
Bruce583102198 1e023f3
fix(build): declare ajv/ajv-formats as plugin runtime deps
CaTeIM aa3cb48
fix(setup): self-heal missing plugin deps after auto-upgrade
CaTeIM f8451fe
fix(setup): address review β scope cooldown per-version, close log fd
CaTeIM 4af8780
fix(chroma): spawn uvx directly on Windows instead of via cmd.exe
PulseCheckAI e060a67
fix(hooks): remove tr space-to-colon that corrupts Windows paths withβ¦
YOMXXX df54526
test(chroma): restore process.env.ComSpec in afterAll to prevent env β¦
thedotmack 9760556
Merge branch 'pr-2636' into windows-canary
thedotmack 48bb064
Merge branch 'pr-2599' into windows-canary
thedotmack 25be77c
Merge branch 'pr-2502' into windows-canary
thedotmack 631aa11
Merge branch 'pr-2593' into windows-canary
thedotmack c87de0f
Merge branch 'pr-2668' into windows-canary
thedotmack 3dc8143
Merge branch 'pr-2208' into windows-canary
thedotmack 5531b2f
Merge branch 'pr-2507' into windows-canary
thedotmack 207fe00
Merge branch 'pr-2598' into windows-canary
thedotmack 68040a0
Merge branch 'pr-2654' into windows-canary
thedotmack a28382a
Merge branch 'pr-2489' into windows-canary
thedotmack b6573ac
Merge branch 'pr-2594' into windows-canary
thedotmack bcf437f
build: regenerate bundles from merged Windows-canary source
thedotmack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The launcher forwards
SIGTERM,SIGINT, andSIGHUPto the child. The exit handler callsprocess.kill(process.pid, sig)when the child exits due to a signal. If this throws on Windows (where many POSIX signals are unsupported), the catch branch callsprocess.exit(128)β a non-zero, non-standard exit code. Callers that check the launcher's exit code for success/failure may misinterpret 128 as an error, even though the child itself may have exited cleanly.Prompt To Fix With AI