feat: ignore Codex and Codex-app internal system prompts

[pg-adm1n]

This PR ignores Codex and Codex-app internal system-initiated prompts (e.g., session title generation, memory consolidation agent, and suggestions overview) to prevent triggering unnecessary session initialization and hook events.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ffcf27481a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Narrow the Memory Writing Agent prefix check

For any user-authored prompt that begins with a markdown heading like ## Memory Writing Agent (for example asking the assistant to draft or review a prompt/template with that heading), this returns true and the session-init callers drop the prompt before creating/saving the session. Because the check is based only on this short prefix rather than the full internal prompt shape or metadata identifying an internal Codex event, legitimate prompts in all supported hook paths can be skipped and excluded from memory tracking.

Useful? React with 👍 / 👎.

[greptile-apps]

Greptile Summary

This PR adds isInternalSystemPrompt to filter out Codex and Codex-app internal system-initiated prompts (session title generation, Memory Writing Agent consolidation, and suggestions overview) from triggering session initialization and hook events. Both the CLI handler and HTTP route are updated to short-circuit on these prompts alongside the existing isInternalProtocolPayload check.

• src/utils/tag-stripping.ts: New isInternalSystemPrompt function using startsWith matching for three known Codex internal prompt prefixes, with trim() normalisation and CRLF handling.
• src/services/worker/http/routes/SessionRoutes.ts and src/cli/handlers/session-init.ts: Both skip paths widened to isInternalProtocolPayload || isInternalSystemPrompt; the HTTP route's reason field in the skip response remains 'internal_protocol' even for the new system-prompt case.
• tests/utils/tag-stripping.test.ts: New test suite for isInternalSystemPrompt covering empty input, false-positive guards, whitespace trimming, and all three prompt categories including CRLF variants.

Confidence Score: 3/5

Safe to merge once the stale reason field in the HTTP skip response is corrected.

The HTTP route returns reason: 'internal_protocol' unconditionally even when the skip is triggered by isInternalSystemPrompt. Any caller or monitoring rule reading that field will get wrong data on every system-prompt skip.

src/services/worker/http/routes/SessionRoutes.ts needs the skip response reason field updated to reflect the actual cause when isInternalSystemPrompt fires.

Important Files Changed

Filename	Overview
src/utils/tag-stripping.ts	Adds isInternalSystemPrompt with three startsWith guards; first Memory Writing Agent condition is redundant dead code.
src/services/worker/http/routes/SessionRoutes.ts	Widens the session-init skip condition to include isInternalSystemPrompt, but reason: 'internal_protocol' in the JSON response is incorrect when the skip is driven by the new function.
src/cli/handlers/session-init.ts	CLI handler mirrors the HTTP route change; no response payload carries a reason field here so the stale-reason bug is absent.
tests/utils/tag-stripping.test.ts	Good coverage of all three new branches including whitespace-trimming and CRLF variants; no test gaps identified.

Prompt To Fix All With AI

Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
src/services/worker/http/routes/SessionRoutes.ts:321
**Stale `reason` field when skipping internal system prompts**

When `isInternalSystemPrompt(rawPrompt)` is the match (and `isInternalProtocolPayload` is not), the response still emits `reason: 'internal_protocol'`. Any downstream client, monitoring pipeline, or log query keyed on `reason` to distinguish skip types will silently receive the wrong label for this new skip path. The `reason` should reflect the actual cause — for example `'internal_system_prompt'` — or the two checks should be reported with separate values.

```suggestion
      res.json({ skipped: true, reason: isInternalProtocolPayload(rawPrompt) ? 'internal_protocol' : 'internal_system_prompt' });
```

### Issue 2 of 2
src/utils/tag-stripping.ts:80-83
The first condition `trimmed.startsWith('## Memory Writing Agent: Phase 2 (Consolidation)')` is dead code — any string that starts with the longer Phase 2 prefix also starts with `'## Memory Writing Agent'`, so the second condition always fires first via short-circuit evaluation. The specific Phase 2 check can be removed without changing behaviour.

```suggestion
  // 2. Memory Writing Agent consolidation prompt
  if (trimmed.startsWith('## Memory Writing Agent')) {
    return true;
  }
```

_{Reviews (1): Last reviewed commit: "feat: ignore Codex and Codex-app interna..." | Re-trigger Greptile}

[greptile-apps]

Stale reason field when skipping internal system prompts

When isInternalSystemPrompt(rawPrompt) is the match (and isInternalProtocolPayload is not), the response still emits reason: 'internal_protocol'. Any downstream client, monitoring pipeline, or log query keyed on reason to distinguish skip types will silently receive the wrong label for this new skip path. The reason should reflect the actual cause — for example 'internal_system_prompt' — or the two checks should be reported with separate values.

Suggested change

	res.json({ skipped: true, reason: 'internal_protocol' });
	res.json({ skipped: true, reason: isInternalProtocolPayload(rawPrompt) ? 'internal_protocol' : 'internal_system_prompt' });

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/services/worker/http/routes/SessionRoutes.ts
Line: 321

Comment:
**Stale `reason` field when skipping internal system prompts**

When `isInternalSystemPrompt(rawPrompt)` is the match (and `isInternalProtocolPayload` is not), the response still emits `reason: 'internal_protocol'`. Any downstream client, monitoring pipeline, or log query keyed on `reason` to distinguish skip types will silently receive the wrong label for this new skip path. The `reason` should reflect the actual cause — for example `'internal_system_prompt'` — or the two checks should be reported with separate values.

```suggestion
      res.json({ skipped: true, reason: isInternalProtocolPayload(rawPrompt) ? 'internal_protocol' : 'internal_system_prompt' });
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

The first condition trimmed.startsWith('## Memory Writing Agent: Phase 2 (Consolidation)') is dead code — any string that starts with the longer Phase 2 prefix also starts with '## Memory Writing Agent', so the second condition always fires first via short-circuit evaluation. The specific Phase 2 check can be removed without changing behaviour.

Suggested change

	// 2. Memory Writing Agent consolidation prompt
	if (trimmed.startsWith('## Memory Writing Agent: Phase 2 (Consolidation)') || trimmed.startsWith('## Memory Writing Agent')) {
	return true;
	}
	// 2. Memory Writing Agent consolidation prompt
	if (trimmed.startsWith('## Memory Writing Agent')) {
	return true;
	}

Prompt To Fix With AI

This is a comment left during a code review.
Path: src/utils/tag-stripping.ts
Line: 80-83

Comment:
The first condition `trimmed.startsWith('## Memory Writing Agent: Phase 2 (Consolidation)')` is dead code — any string that starts with the longer Phase 2 prefix also starts with `'## Memory Writing Agent'`, so the second condition always fires first via short-circuit evaluation. The specific Phase 2 check can be removed without changing behaviour.

```suggestion
  // 2. Memory Writing Agent consolidation prompt
  if (trimmed.startsWith('## Memory Writing Agent')) {
    return true;
  }
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!