configuration["discovery_filter"] fix test for Docker & HA Add-on #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DigiH
force-pushed
the
filter
branch
2 times, most recently
from
a402139 to
50fd625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need testing and verification with the Docker image and HA Add-on.
The HA Add-on also converts identities to a whole string, which Docker keeps it as a dictionary, same for bindkeys.
Would and should it not be possible and preferable to make any such type format conversions, if and when required, in the projects themselves, so that the underlying config file can be assumed to be identical across all incarnations of Theengs Gateway?
I assume though that it comes from writing any new additions to discovery_filter in the HA Add-on text field, and for Docker it is also already specified as a string in the run arguments
Checklist: