add support for repo_data parameter in registration_command module #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
approved these changes
Dec 11, 2025
| repo: | ||
| description: | ||
| - Repository URL (yum/dnf) or full sources.list entry (apt). | ||
| - "Deprecated: Use the I(repo_data) option instead." |
Member
There was a problem hiding this comment.
Should we note that it's deprecated since 3.11?
Contributor
Author
There was a problem hiding this comment.
I can just add a note to the description of the option: "This option was deprecated in version 3.11.0."
Is that okay?
Member
There was a problem hiding this comment.
I'd do "Forman 3.11" so people are not confused with the version of the Ansible collection, but otherwise yeah that's what I meant!
Contributor
Author
|
Done. Added a note that the 'repo' and 'repo_gg_key_url' parameters have been deprecated since Foreman version 3.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add repo_data parameter support to registration_command module
Fixes #1938