smart_proxy lifecycle environment scoping - #1984
Open
tyderian1978 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to: #1463
Lifecycle Environment names are only unique within an organization. smart_proxy's lifecycle_environments lookup didn't scope by organization at all, so if two orgs each had an LCE with the same name (e.g. library), the lookup could match the wrong one (or fail as ambiguous) depending on which org's LCE happened to resolve first.
This mirrors a bug already fixed for content_view #1980, which added scope=['organization'] to that module's declarative foreman_spec.
smart_proxy can't use the same declarative approach because it pops lifecycle_environments out of foreman_params and applies it via a separate PUT .../capsules/:id/content/lifecycle_environments call rather than through the entity's own create/update payload.