Fixes #SAT-31687 - Deprecate oVirt #3724
Conversation
github-actions
bot
added
Needs tech review
|
The PR preview for c0666a7 is available at theforeman-foreman-documentation-preview-pr-3724.surge.sh The following output files are affected by this PR: |
| === Compute resources - oVirt | ||
| * The oVirt compute resource has been deprecated and will be removed in a future release. | ||
| * Migrate your data with the "foreman-rake ovirt:drop" task. |
There was a problem hiding this comment.
| === Compute resources - oVirt | |
| * The oVirt compute resource has been deprecated and will be removed in a future release. | |
| * Migrate your data with the "foreman-rake ovirt:drop" task. | |
| === The {oVirt} compute resource | |
| The {oVirt} compute resource has been deprecated and will be removed in a future release. | |
| Migrate your data with the `foreman-rake ovirt:drop` comand. |
There was a problem hiding this comment.
A bit more information about what the rake command does and what happens during the migration would be useful. Alternatively, you could just link to docs that explain it but I don't think we have them (yet).
There was a problem hiding this comment.
... or just what @maximiliankolb said :) Looks like he was faster with his review.
|
Updated formatting. About the rake task description, I'll describe it in the release notes as well, once the theforeman/foreman#10469 get merged. |
| There are no deprecations with Foreman {ProjectVersion}. | ||
| === Compute resources - {oVirt} | ||
|
|
||
| * The {oVirt} compute resource has been deprecated and will be removed in a future release. |
There was a problem hiding this comment.
A concrete timeline is always appreciated, if available.
| @@ -15,4 +15,7 @@ There are no upgrade warnings with Foreman {ProjectVersion}. | |||
| [id="foreman-deprecations"] | |||
| == Deprecations | |||
|
|
|||
| There are no deprecations with Foreman {ProjectVersion}. | |||
| === Compute resources - {oVirt} | |||
There was a problem hiding this comment.
We usually refer to the RFC so please include a link to https://community.theforeman.org/t/rfc-deprecation-and-removal-of-ovirt-compute-resource/42527.
| @@ -15,4 +15,7 @@ There are no upgrade warnings with Foreman {ProjectVersion}. | |||
| [id="foreman-deprecations"] | |||
| == Deprecations | |||
|
|
|||
| There are no deprecations with Foreman {ProjectVersion}. | |||
| === Compute resources - {oVirt} | |||
There was a problem hiding this comment.
| === Compute resources - {oVirt} | |
| // There are no deprecations with Foreman {ProjectVersion}. | |
| === Compute resources - {oVirt} |
suggestion: Please keep this handly little sentence on "master". Not blocking your PR because we could also revert any commits after branching on master again. However, it might be easier to just drop any release notes after branching 3.15.
If there is a new plugin and that's used in upstream, then IMHO it shouldn't be deprecated. Instead we should point out (at least in upstream) that it's going be migrated. Until that's decided I don't think we should merge this. In other words, only once consensus is reached in https://community.theforeman.org/t/rfc-deprecation-and-removal-of-ovirt-compute-resource/42527 should we proceed with steps. |
What changes are you introducing?
oVirt integration is going to be deprecated in 3.15 and removed in 3.16
Why are you introducing these changes?
https://community.theforeman.org/t/rfc-deprecation-and-removal-of-ovirt-compute-resource/42527
https://projects.theforeman.org/issues/38266
https://issues.redhat.com/browse/SAT-12005
Anything else to add?
@maximiliankolb Atix folks probably take over the ownership and extract the code to the plugin, so there should be a doc variant for your docs.