Skip to content

Fix REX provider type#4434

Merged
maximiliankolb merged 3 commits intotheforeman:masterfrom
ATIX-AG:fix_4415_SSH_provider
Nov 18, 2025
Merged

Fix REX provider type#4434
maximiliankolb merged 3 commits intotheforeman:masterfrom
ATIX-AG:fix_4415_SSH_provider

Conversation

@maximiliankolb
Copy link
Copy Markdown
Contributor

@maximiliankolb maximiliankolb commented Oct 27, 2025

What changes are you introducing?

  • Package Action: foreman_remote_execution -> app/views/templates/script/package_action.erb
  • Power Action: foreman_remote_execution -> app/views/templates/script/power_action.erb
  • Puppet Run Once: foreman_puppet -> app/views/templates/script/puppet_run_once.erb
  • Service Action: foreman_remote_execution -> app/views/templates/script/service_action.erb

Salt: No change in "guides/common/modules/proc_running-salt.adoc" but looked into this issue via PR 219 in foreman_salt. (Untested but verified that the templates are currently called "Salt Run function - SSH default".

Clicking "Run Puppet once" in WebUI really causes REX to start a job that uses the "Puppet Run Once - Script Default" template.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Fixes #4415 (Rename REX provider)

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Tested on Foreman 3.16 but tech ACK would be appreciated.

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.16/Katello 4.18 (Satellite 6.18)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only; orcharhino 7.0 on EL8+EL9; orcharhino 7.1 with Leapp)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • We do not accept PRs for Foreman older than 3.9.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Oct 27, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 27, 2025 •
edited
Loading

The PR preview for 01808fd is available at theforeman-foreman-documentation-preview-pr-4434.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

Lennonka
Lennonka approved these changes Oct 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I guess this could be cherry picked farther, but I'm not sure how far. Can you check with someone, please?

@Lennonka Lennonka added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Oct 28, 2025
@maximiliankolb maximiliankolb mentioned this pull request Oct 29, 2025
Closed
10 tasks
@aneta-petrova aneta-petrova linked an issue Oct 29, 2025 that may be closed by this pull request
Update procedure for running Puppet once with ssh #4192
Closed
aneta-petrova
aneta-petrova reviewed Oct 29, 2025
View reviewed changes
Comment thread guides/common/modules/proc_running-puppet-once-using-ssh.adoc
@maximiliankolb
Fix REX provider type
5441389 
* Package Action: foreman_remote_execution -> app/views/templates/script/package_action.erb
* Power Action: foreman_remote_execution -> app/views/templates/script/power_action.erb
* Puppet Run Once: foreman_puppet -> app/views/templates/script/puppet_run_once.erb
* Service Action: foreman_remote_execution -> app/views/templates/script/service_action.erb

Salt: No change in "guides/common/modules/proc_running-salt.adoc" but
looked into this issue via PR 219 in foreman_salt. (Untested but
verified that the templates are currently called "Salt Run function - SSH default".

Clicking "Run Puppet once" in WebUI really causes REX to start a job
that uses the "Puppet Run Once - Script Default" template.

Tested on Foreman 3.16

Fixes theforeman#4415 (Rename REX provider)
@maximiliankolb
fixup! Fix REX provider type
268a56b 
Fixes theforeman#4192
@maximiliankolb
Copy link
Copy Markdown
Contributor Author

maximiliankolb commented Oct 30, 2025

I checked on Foreman 3.16:

puppet-rex-feature puppet-schedule-job

The wording in the WebUI is weird! Can you please check if my second commit makes sense to you? @aneta-petrova

@maximiliankolb
Use canceled in favor of cancelled
01808fd 
"guides/common/modules/con_host-substatus-overview.adoc" remains
unchanged because the wording seems to come from the WebUI.

This makes vale happy.
@maximiliankolb
Copy link
Copy Markdown
Contributor Author

maximiliankolb commented Nov 18, 2025

@aneta-petrova Can you please re-check if that works for you?

@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Nov 18, 2025
@maximiliankolb maximiliankolb merged commit dfad7d7 into theforeman:master Nov 18, 2025
10 checks passed
@maximiliankolb maximiliankolb deleted the fix_4415_SSH_provider branch November 18, 2025 13:33
maximiliankolb added a commit that referenced this pull request Nov 18, 2025
@maximiliankolb
Fix REX provider type (#4434)
124aab5 
* Fix REX provider type
** Package Action: foreman_remote_execution -> app/views/templates/script/package_action.erb
** Power Action: foreman_remote_execution -> app/views/templates/script/power_action.erb
** Puppet Run Once: foreman_puppet -> app/views/templates/script/puppet_run_once.erb
** Service Action: foreman_remote_execution -> app/views/templates/script/service_action.erb
* Salt: No change in "guides/common/modules/proc_running-salt.adoc" but
  looked into this issue via PR 219 in foreman_salt. (Untested but
  verified that the templates are currently called "Salt Run function - SSH default".
* Clicking "Run Puppet once" in WebUI really causes REX to start a job
  that uses the "Puppet Run Once - Script Default" template.
  Tested on Foreman 3.16
* Use canceled in favor of cancelled
  "guides/common/modules/con_host-substatus-overview.adoc" remains
  unchanged because the wording seems to come from the WebUI.
  This makes vale happy.

Fixes #4415 (Rename REX provider)
Fixes #4192 (Rename Puppet Run Once template)

(cherry picked from commit dfad7d7)
maximiliankolb added a commit that referenced this pull request Nov 18, 2025
@maximiliankolb
Fix REX provider type (#4434)
c9b47d7 
* Fix REX provider type
** Package Action: foreman_remote_execution -> app/views/templates/script/package_action.erb
** Power Action: foreman_remote_execution -> app/views/templates/script/power_action.erb
** Puppet Run Once: foreman_puppet -> app/views/templates/script/puppet_run_once.erb
** Service Action: foreman_remote_execution -> app/views/templates/script/service_action.erb
* Salt: No change in "guides/common/modules/proc_running-salt.adoc" but
  looked into this issue via PR 219 in foreman_salt. (Untested but
  verified that the templates are currently called "Salt Run function - SSH default".
* Clicking "Run Puppet once" in WebUI really causes REX to start a job
  that uses the "Puppet Run Once - Script Default" template.
  Tested on Foreman 3.16
* Use canceled in favor of cancelled
  "guides/common/modules/con_host-substatus-overview.adoc" remains
  unchanged because the wording seems to come from the WebUI.
  This makes vale happy.

Fixes #4415 (Rename REX provider)
Fixes #4192 (Rename Puppet Run Once template)

(cherry picked from commit dfad7d7)
@maximiliankolb
Copy link
Copy Markdown
Contributor Author

maximiliankolb commented Nov 18, 2025

Merged to "master" and cherry-picked:
27b1a95..124aab5 3.17 -> 3.17
741b489..c9b47d7 3.16 -> 3.16

I do not have access to Foreman 3.14 right now, so I cannot check if we could cherry-pick this further. Input welcome.

@aneta-petrova
Copy link
Copy Markdown
Member

aneta-petrova commented Nov 18, 2025

I do not have access to Foreman 3.14 right now, so I cannot check if we could cherry-pick this further. Input welcome.

Does this help @maximiliankolb?

Screenshot From 2025-11-18 15-55-47

This is from Satellite 6.17, which is the equivalent of Foreman 3.14.

maximiliankolb added a commit that referenced this pull request Nov 19, 2025
@maximiliankolb
Fix REX provider type (#4434)
85e6509 
* Fix REX provider type
** Package Action: foreman_remote_execution -> app/views/templates/script/package_action.erb
** Power Action: foreman_remote_execution -> app/views/templates/script/power_action.erb
** Puppet Run Once: foreman_puppet -> app/views/templates/script/puppet_run_once.erb
** Service Action: foreman_remote_execution -> app/views/templates/script/service_action.erb
* Salt: No change in "guides/common/modules/proc_running-salt.adoc" but
  looked into this issue via PR 219 in foreman_salt. (Untested but
  verified that the templates are currently called "Salt Run function - SSH default".
* Clicking "Run Puppet once" in WebUI really causes REX to start a job
  that uses the "Puppet Run Once - Script Default" template.
  Tested on Foreman 3.16
* Use canceled in favor of cancelled
  "guides/common/modules/con_host-substatus-overview.adoc" remains
  unchanged because the wording seems to come from the WebUI.
  This makes vale happy.

Fixes #4415 (Rename REX provider)
Fixes #4192 (Rename Puppet Run Once template)

(cherry picked from commit dfad7d7)
(cherry picked from commit c9b47d7)

Resolved a minor merge conflict while cherry-picking from 3.16 to 3.15
in "guides/common/modules/proc_running-puppet-once-using-ssh.adoc".
maximiliankolb added a commit that referenced this pull request Nov 19, 2025
@maximiliankolb
Fix REX provider type (#4434)
3ad8f73 
* Fix REX provider type
** Package Action: foreman_remote_execution -> app/views/templates/script/package_action.erb
** Power Action: foreman_remote_execution -> app/views/templates/script/power_action.erb
** Puppet Run Once: foreman_puppet -> app/views/templates/script/puppet_run_once.erb
** Service Action: foreman_remote_execution -> app/views/templates/script/service_action.erb
* Salt: No change in "guides/common/modules/proc_running-salt.adoc" but
  looked into this issue via PR 219 in foreman_salt. (Untested but
  verified that the templates are currently called "Salt Run function - SSH default".
* Clicking "Run Puppet once" in WebUI really causes REX to start a job
  that uses the "Puppet Run Once - Script Default" template.
  Tested on Foreman 3.16
* Use canceled in favor of cancelled
  "guides/common/modules/con_host-substatus-overview.adoc" remains
  unchanged because the wording seems to come from the WebUI.
  This makes vale happy.

Fixes #4415 (Rename REX provider)
Fixes #4192 (Rename Puppet Run Once template)

(cherry picked from commit dfad7d7)
(cherry picked from commit c9b47d7)

Resolved a minor merge conflict while cherry-picking from 3.16 to 3.15
in "guides/common/modules/proc_running-puppet-once-using-ssh.adoc".

(cherry picked from commit 85e6509)
@maximiliankolb
Copy link
Copy Markdown
Contributor Author

maximiliankolb commented Nov 19, 2025

Thanks Anet. More cherry-picks:
06f1f12..85e6509 3.15 -> 3.15
ba7baef..3ad8f73 3.14 -> 3.14

jafiala pushed a commit to jafiala/foreman-documentation that referenced this pull request Feb 26, 2026
@maximiliankolb @jafiala
Fix REX provider type (theforeman#4434)
43f70cc 
* Fix REX provider type
** Package Action: foreman_remote_execution -> app/views/templates/script/package_action.erb
** Power Action: foreman_remote_execution -> app/views/templates/script/power_action.erb
** Puppet Run Once: foreman_puppet -> app/views/templates/script/puppet_run_once.erb
** Service Action: foreman_remote_execution -> app/views/templates/script/service_action.erb
* Salt: No change in "guides/common/modules/proc_running-salt.adoc" but
  looked into this issue via PR 219 in foreman_salt. (Untested but
  verified that the templates are currently called "Salt Run function - SSH default".
* Clicking "Run Puppet once" in WebUI really causes REX to start a job
  that uses the "Puppet Run Once - Script Default" template.
  Tested on Foreman 3.16
* Use canceled in favor of cancelled
  "guides/common/modules/con_host-substatus-overview.adoc" remains
  unchanged because the wording seems to come from the WebUI.
  This makes vale happy.

Fixes theforeman#4415 (Rename REX provider)
Fixes theforeman#4192 (Rename Puppet Run Once template)

(cherry picked from commit dfad7d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aneta-petrova aneta-petrova aneta-petrova approved these changes

@Lennonka Lennonka Lennonka approved these changes

+1 more reviewer

@sbernhard sbernhard sbernhard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The template type has been renamed from "SSH" to "Script" Update procedure for running Puppet once with ssh

4 participants

@maximiliankolb @aneta-petrova @Lennonka @sbernhard