Use "client-os" attribute where possible#4791
Open
maximiliankolb wants to merge 4 commits intotheforeman:masterfrom
Open
Use "client-os" attribute where possible#4791maximiliankolb wants to merge 4 commits intotheforeman:masterfrom
maximiliankolb wants to merge 4 commits intotheforeman:masterfrom
Conversation
This patch ensures that the examples are only shown for RHEL Clients because the examples reference the Red Hat products page which is not used for EL in general.
In downstream orcharhino builds, the module is included based on the Client OS. Therefore, this admonition does not make any sense for orcharhino builds.
The attribute referes to the platform OS of Foreman/Smart Proxy. Therefore, it's independent on the Client OS, which can be any Enterprise Linux, SLES, or Debian/Ubuntu etc. This patch ensures that the attribute is not overwritten by "Oracle Linux" in orcharhino downstream builds. In the guide for Oracle Linux, Oracle Linux is the Client OS. Users can provision/manage hosts running Oracle Linux with orcharhino on any platform OS. Refs https://docs.orcharhino.com/or/docs/sources/guides/oracle_linux/provisioning_hosts/using_network_boot_to_provision_hosts.html#Configuring_iPXE_Environment_using-network-boot
github-actions
Bot
added
Needs tech review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Use
client-osattribute in favor ofELwhere possible.Why are you introducing these changes? (Explanation, links to references, issues, etc.)
In downstream, the Client OS differs from the EL attribute.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Please review commit by commit.
Contributor checklists
Please cherry-pick my commits into: