Add foremanctl commands for IoP - #5096
Open
Lennonka wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
Needs tech review
| ---- | ||
| endif::[] | ||
| ifdef::containerized[] | ||
| .. Create a `config.yml` file that includes the following logging levels together with the required IOP core engine configuration: |
Contributor
There was a problem hiding this comment.
I would either say "IoP" or use the attribute https://github.com/theforeman/foreman-documentation/blob/master/guides/common/attributes-base.adoc#L174
same applies to line 76.
| ---- | ||
| # {foreman-installer} --enable-iop | ||
| ifndef::containerized[# {foreman-installer} --enable-iop] | ||
| ifdef::containerized[# {foremanctl} deploy --add-feature iop] |
Contributor
There was a problem hiding this comment.
if it's the same like line 24, then maybe a different structure is better because users do not need to know if they used IoP before.
Contributor
Author
|
@maximiliankolb Thanks a lot for your notes! I will need a tech review first because it will decide how to proceed further. |
Lennonka
force-pushed
the
add-foremanctl-to-enable-iop
branch
2 times, most recently
from
July 23, 2026 14:58
82569d4 to
2040262
Compare
ehelms
reviewed
Jul 24, 2026
| "": | ||
| level: "DEBUG" | ||
| ---- | ||
| .. Replace the `iop-core-engine-config-yml` Podman secret: |
Member
There was a problem hiding this comment.
I don't love this as a procedure that we are telling users to do. @vkrizan Do you think we should add this as a logging option in foremanctl ?
Lennonka
force-pushed
the
add-foremanctl-to-enable-iop
branch
2 times, most recently
from
July 28, 2026 14:54
0dfcb0c to
4986cc4
Compare
Lennonka
force-pushed
the
add-foremanctl-to-enable-iop
branch
from
July 28, 2026 15:10
4986cc4 to
314c2a9
Compare
Co-authored-by: Maximilian Kolb <mail@maximilian-kolb.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Adding foremanctl commands for IoP in containerized Foreman:
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Containerization
SAT-40194
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: N/A