Skip to content

Remove registering upstream - #5115

Open
jafiala wants to merge 2 commits into
theforeman:masterfrom
jafiala:remove-registering-upstream
Open

Remove registering upstream#5115
jafiala wants to merge 2 commits into
theforeman:masterfrom
jafiala:remove-registering-upstream

Conversation

@jafiala

@jafiala jafiala commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

What changes are you introducing?

Remove registration from upstream proxy installation

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Separate PR that was part of install-containerized-proxy

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.19/Katello 4.21
  • Foreman 3.18/Katello 4.20 (Satellite 6.19; orcharhino 7.9)
  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6, 7.7, and 7.8)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • We do not accept PRs for Foreman older than 3.14.

@github-actions github-actions Bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jul 29, 2026
@jafiala jafiala removed the Needs testing Requires functional testing label Jul 29, 2026
@github-actions

Copy link
Copy Markdown

The PR preview for 595f8e5 is available at theforeman-foreman-documentation-preview-pr-5115.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@ekohl

ekohl commented Jul 29, 2026

Copy link
Copy Markdown
Member

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

FYI: I asked for this. Today in upstream a content proxy doesn't pull content from the Katello server but instead directly from the internet. That makes me think the registration isn't needed and we can simplify the process. However, I may be missing something.

To keep the containerized PR simple, I've asked @jafiala to open a separate PR so we can look at it independently.

@jafiala
jafiala marked this pull request as ready for review July 29, 2026 10:17

@maximiliankolb maximiliankolb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style-wise LGTM. I am not sure if the macros can be simplified, but IMO it's OK as is.

@maximiliankolb maximiliankolb added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jul 30, 2026
ifndef::orcharhino[]
For more information, see xref:registering-{smart-proxy-context}-server[].
endif::[]
endif::[]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this redundant now?

Suggested change
endif::[]
ifdef::satellite[]
For more information, see xref:registering-{smart-proxy-context}-server[].
endif::[]

Though arguably, the whole prerequisite to have it registered is now only true for Satellite, isn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs tech review Requires a review from the technical perspective style review done No issues from docs style/grammar perspective

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants