Remove registering upstream - #5115
Conversation
|
The PR preview for 595f8e5 is available at theforeman-foreman-documentation-preview-pr-5115.surge.sh The following output files are affected by this PR: |
FYI: I asked for this. Today in upstream a content proxy doesn't pull content from the Katello server but instead directly from the internet. That makes me think the registration isn't needed and we can simplify the process. However, I may be missing something. To keep the containerized PR simple, I've asked @jafiala to open a separate PR so we can look at it independently. |
maximiliankolb
left a comment
There was a problem hiding this comment.
style-wise LGTM. I am not sure if the macros can be simplified, but IMO it's OK as is.
| ifndef::orcharhino[] | ||
| For more information, see xref:registering-{smart-proxy-context}-server[]. | ||
| endif::[] | ||
| endif::[] |
There was a problem hiding this comment.
Isn't this redundant now?
| endif::[] | |
| ifdef::satellite[] | |
| For more information, see xref:registering-{smart-proxy-context}-server[]. | |
| endif::[] |
Though arguably, the whole prerequisite to have it registered is now only true for Satellite, isn't it?
What changes are you introducing?
Remove registration from upstream proxy installation
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Separate PR that was part of install-containerized-proxy
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: