Fixes #38313 - make case insensitive for SAN entries and Subject CN on certificate#1022
Open
takaelucky wants to merge 1 commit intotheforeman:developfrom
Open
Fixes #38313 - make case insensitive for SAN entries and Subject CN on certificate#1022takaelucky wants to merge 1 commit intotheforeman:developfrom
takaelucky wants to merge 1 commit intotheforeman:developfrom
Conversation
ekohl
reviewed
Mar 25, 2025
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I think in the past we did have code which didn't deal well with this so I wonder if we solved all instances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
katello-certs-check will error when the certificate has the same FQDN in CN and SAN, but one is uppercase and another is in lowercase.
With this change, both FQDN will lowercase and check will not fail