Fixes #31119 - run katello-certs-check when installing with custom certs#579
Merged
wbclark merged 1 commit intotheforeman:developfrom Oct 23, 2020
Merged
Conversation
Member
|
I think you can rebase this now @wbclark |
wbclark
force-pushed
the
katello-certs-check
branch
from
a28af7a to
7cdcb70
Compare
Contributor
Author
|
Rebased and ready for review |
Member
|
Looks like the tests don't like the expired certificate, other than that I think this makes sense. Edit: perhaps this also deserves a Redmine issue for the changelog? |
ekohl
requested changes
Oct 21, 2020
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Please open a Redmine issue for this and use a more descriptive commit message, other than that 👍
wbclark
force-pushed
the
katello-certs-check
branch
from
7cdcb70 to
aa3a6c3
Compare
wbclark
changed the title
ekohl
reviewed
Oct 21, 2020
wbclark
force-pushed
the
katello-certs-check
branch
from
aa3a6c3 to
aaee541
Compare
ekohl
approved these changes
Oct 21, 2020
wbclark
force-pushed
the
katello-certs-check
branch
from
aaee541 to
bed69f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #514