Fixes #38274 - Updated docker-compose.yml that fixes the issues outli… #10472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
reviewed
Mar 13, 2025
| environment: | ||
| - POSTGRES_USER=foreman |
There was a problem hiding this comment.
I still like the dedicated user just for Foreman. That's closer to what we have in production
| test: ["CMD-SHELL", "nc -z 127.0.0.1 5432 || exit 1"] | ||
| interval: 30s | ||
| timeout: 30s | ||
| test: ["CMD-SHELL", "pg_isready"] |
| - /bin/bash | ||
| - -c | ||
| - | | ||
| bundle exec bin/rake db:reset |
There was a problem hiding this comment.
Doesn't this wipe the DB on every restart? I don't like that if I'm honest. Too easy to lose work.
| - RAILS_MAX_THREADS=5 | ||
| - RAILS_ENV=production | ||
| - FOREMAN_FQDN=foreman.example.com | ||
| - FOREMAN_DOMAIN=example.com | ||
| - FOREMAN_RAILS_CACHE_STORE_TYPE=redis | ||
| - FOREMAN_RAILS_CACHE_STORE_URLS=redis://redis-cache:6379/0 | ||
| - DYNFLOW_REDIS_URL=redis://redis-tasks:6379/0 | ||
| - REDIS_PROVIDER=DYNFLOW_REDIS_URL | ||
| - REDIS_PROVIDER=$DYNFLOW_REDIS_URL |
There was a problem hiding this comment.
I don't think this is right. Looking at https://github.com/sidekiq/sidekiq/blob/77c6052e4d2d9ccc26457b4a2d629c33a9456664/lib/sidekiq/redis_connection.rb#L93-L98 it should be the name of the env var that contains the real URL.
| hostname: orchestrator.example.com | ||
| ports: [] | ||
| ## Not required | ||
| # orchestrator: |
There was a problem hiding this comment.
This and the worker are needed for tasking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ned in bug.
Fixes #38274 - Updated docker-compose.yml that fixes the issues outlined in bug.
https://projects.theforeman.org/issues/38274
Fixes app services exiting with error multiple PG::UndefinedTable: errors by moving the database creation to the app service. The database is dropped (if exists), recreated and configured by foreman to ensure all tables are created successfully.