Fixes #39426 - Better ouiaId for ActionButtons on TableIndexPage#11025
Open
sambible wants to merge 1 commit into
Open
Fixes #39426 - Better ouiaId for ActionButtons on TableIndexPage#11025sambible wants to merge 1 commit into
sambible wants to merge 1 commit into
Conversation
sambible
changed the title
sambible
force-pushed
the
fixes-39426-better-ouiaid-actionbutton-tableindexpage
branch
from
f149203 to
db12ba3
Compare
qcjames53
suggested changes
Jun 16, 2026
qcjames53
left a comment
qcjames53
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR Sam! I think the changes look pretty good to me but it needs one logic tweak to work.
| <> | ||
| <Button | ||
| ouiaId="action-buttons-button" | ||
| ouiaId={firstButton.ouiaId ? undefined : "action-buttons-button"} |
Contributor
There was a problem hiding this comment.
Suggested change
| ouiaId={firstButton.ouiaId ? undefined : "action-buttons-button"} | |
| ouiaId={firstButton.ouiaId || 'action-buttons-button'} |
With your approach I think you'd want to use a solution like this. I believe the existing ternary doesn't work.
sambible
force-pushed
the
fixes-39426-better-ouiaid-actionbutton-tableindexpage
branch
from
db12ba3 to
2039322
Compare
qcjames53
suggested changes
Jun 16, 2026
| /** | ||
| * Generate a button or a dropdown of buttons | ||
| * @param {String} title The title of the button for the title and text inside the button | ||
| * @param {String} ouiaId If included, use this as the ouiaId |
Contributor
There was a problem hiding this comment.
One nitpick, there's a trailing space here. Would you mind deleting it please?
sambible
force-pushed
the
fixes-39426-better-ouiaid-actionbutton-tableindexpage
branch
from
2039322 to
af9c4d3
Compare
qcjames53
approved these changes
Jun 16, 2026
qcjames53
left a comment
qcjames53
left a comment
Contributor
There was a problem hiding this comment.
This looks great to me, thank you!
Contributor
|
I don't understand why the single commit check is failing but the failing docker pulls appear unrelated. |
Contributor
|
Looks like there are some linting failures |
ianballou
reviewed
Jun 16, 2026
ianballou
left a comment
ianballou
left a comment
Contributor
There was a problem hiding this comment.
This should be good to go once the linting is fixed
Author
|
Thanks, i need to get a precommit process setup, clearly im missing something in my env |
sambible
force-pushed
the
fixes-39426-better-ouiaid-actionbutton-tableindexpage
branch
from
af9c4d3 to
cfb4f89
Compare
ianballou
approved these changes
Jun 16, 2026
ianballou
left a comment
ianballou
left a comment
Contributor
There was a problem hiding this comment.
Thanks! TableIndexPage is still working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates ActionButtons and TableIndexPage to better reflect the function of the various buttons that can appear on TableIndexPage based pages.
Before: ouiaId was always
action-buttons-buttonAfter: ouiaId will be one of
action-buttons-createaction-buttons-exportoraction-buttons-documentationbased on the actual function of the button.