mark steps that were filtered due to confine as skipped #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is especially interesting when running checks, as sometimes a check is not applicable to a system (and thus confined) but we'd still report the result as "OK" which can confuse the user
Member
Author
|
draft, as I don't like the way it's currently rendered (visually too close to a warning), but didn't want to leave that unmentioned after a discussion with @jameerpathan111 |
Contributor
@evgeni How about using Orange color for |
Member
|
I am surprised the check shows up at all if it does not match conditions. If we keep it this way, I like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is especially interesting when running checks, as sometimes a check is not applicable to a system (and thus confined) but we'd still report the result as "OK" which can confuse the user