Fix JS linting error 'no-magic-numbers'#448
Merged
Merged
Conversation
The Foreman linting requires constants to be declared instead of directly assigning numbers to variables. Otherwise, it will through the 'no-magic-numbers' error. Corresponding Foreman core PR: theforeman/foreman#11008 Co-Authored-By: OpenAI Codex
nadjaheitmann
force-pushed
the
fix_magic_numbers
branch
from
July 17, 2026 08:43
5cb54e2 to
339a92e
Compare
Collaborator
Author
|
@MariaAga @adamruzicka Can I get an ACK here, please? I think it's the third PR where I am running into this :) means that code quality improves, I hope |
Collaborator
Author
|
Thanks @MariaAga ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Foreman linting requires constants to be declared instead of directly assigning numbers to variables. Otherwise, it will through the 'no-magic-numbers' error.
Corresponding Foreman core PR:
theforeman/foreman#11008
Co-Authored-By: OpenAI Codex