Fixes #38446 - Move plugin registration to own file#975
Merged
Conversation
adamruzicka
reviewed
Jun 16, 2025
| # e.g. having ProvisioningTemplate < Template, adding has_many :template_inputs to Template from concern | ||
| # Template.reflect_on_association :template_inputs # => <#Association... | ||
| # ProvisioningTemplate.reflect_on_association :template_inputs # => nil | ||
| require_dependency 'job_template' |
Contributor
There was a problem hiding this comment.
Was this never needed or is it not needed anymore?
Contributor
Author
There was a problem hiding this comment.
Added JobTemplate directly in the array below. I think that's correct and the intention of this method call
Contributor
There was a problem hiding this comment.
Now I wonder, if we're in REX, why do we jump through hoops to load the extension into JobTemplate dynamically, but that's probably a thing for another time
jturel
force-pushed
the
engine_plugin_register
branch
from
June 29, 2025 21:31
558d675 to
7dbd8ff
Compare
adamruzicka
approved these changes
Jul 7, 2025
Contributor
|
Thank you @jturel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of work started in #973 to fix code reloading.
The plugin registration calls into a lot of application code. This seems to be the least intrusive way to achieve parity but without registration happening again on each code reload