Replace "Satellite" with "Foreman" in user-facing strings.#897
Merged
Conversation
chris1984
reviewed
Aug 28, 2024
chris1984
left a comment
chris1984
left a comment
Member
There was a problem hiding this comment.
Looks fine, can you fix the failing snapshot JS test?
Thorben-D
force-pushed
the
unbrand_rh_cloud
branch
from
August 28, 2024 14:32
0e7595e to
5af9b49
Compare
Contributor
Author
|
Tests should be working now! |
Member
|
Let's wait for the branching, and then push the PR. We are after the strings were sent to translations, so changing the templates will result in breakage. |
Contributor
|
Is the branching already done @ShimShtein ? |
Member
Branching will happen after we go GA downstream. There is discussion still about the branch name for the next version too. |
Thorben-D
force-pushed
the
unbrand_rh_cloud
branch
from
October 2, 2024 06:31
5af9b49 to
917a85c
Compare
Contributor
Author
|
Rebased to "develop" |
chris1984
approved these changes
Oct 15, 2024
chris1984
left a comment
chris1984
left a comment
Member
There was a problem hiding this comment.
Looks good, Thanks @Thorben-D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a starting point for un-branding this plugin.
Only user-facing strings are un-branded right now. Un-branding environment variables or hash-keys would either break existing usages or create a bit of a mess. I am not sure that would be worth the trouble...
Using
foreman_theme_satellitein conjunction with this plugin re-applies the branding.