Skip to content

Add playbook to pre-pull images#101

Merged
ehelms merged 2 commits intotheforeman:masterfrom
ehelms:pre-pull-images
Mar 7, 2025
Merged

Add playbook to pre-pull images#101
ehelms merged 2 commits intotheforeman:masterfrom
ehelms:pre-pull-images

Conversation

@ehelms
Copy link
Copy Markdown
Member

@ehelms ehelms commented Mar 6, 2025

Pre-pulling the images isn't necessary, but can help differentiate the runtime of the actual installer part vs. image pull.

@ehelms ehelms force-pushed the pre-pull-images branch from 1439adb to 6779cbf Compare March 6, 2025 11:40
Copy link
Copy Markdown
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me think: could we build on this to also build the container images locally? Out of scope for this PR, but it made me think.

@ekohl
Copy link
Copy Markdown
Member

ekohl commented Mar 7, 2025

Test failure looks unrelated.

@ehelms
Copy link
Copy Markdown
Member Author

ehelms commented Mar 7, 2025

This makes me think: could we build on this to also build the container images locally? Out of scope for this PR, but it made me think.

I agree, I have some thoughts there and this could be a useful debugging option.

@ehelms
Copy link
Copy Markdown
Member Author

ehelms commented Mar 7, 2025

Test failure looks unrelated.

Yea... this failure keeps popping up and is intermittent. I am going to see if I can figure out why.

@ekohl
Copy link
Copy Markdown
Member

ekohl commented Mar 7, 2025

I agree, I have some thoughts there and this could be a useful debugging option.

There is podman image scp perhaps (at least in CI) we should build all containers locally, push them into the managed VM and then continue with the next steps.

Copy link
Copy Markdown
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking more: we have podman_image in various roles so you could clearly see when that fails, but systemd will pull on start up anyway and this separate step makes it redundant. Should we drop those instructions from the roles?

Should we also document this in README to recommend users to run it as well?

@ehelms
Copy link
Copy Markdown
Member Author

ehelms commented Mar 7, 2025

Thinking more: we have podman_image in various roles so you could clearly see when that fails, but systemd will pull on start up anyway and this separate step makes it redundant. Should we drop those instructions from the roles?

I am not sure yet, and I think this should depend on our workflow strategy and update strategy. For example, do we want to treat pre-pulling as an optimization or a hard requirement? Do we want a fall back mechanism? How should we expect image updates to happen?

I would guess for updates, like we do today, we want to control and orchestrate that and not leave it up to the whims of a systemd service.

@ehelms ehelms merged commit 869b034 into theforeman:master Mar 7, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants