Conversation
systemd defaults to 90 seconds timeout of a service startup, but candlepin 4.6 seems to require more on the first start when it applies the DB migrations
As we can't rely on the host we run the `foremanpi` fixture on to have correct DNS for `quadlet.example.com`, we use the IP address we get from Vagrant for all communication. Sadly this leaks into the generated registrtion command, which will also use the IP address instead of the hostname, even tho the client system has correct DNS (via `/etc/hosts`). Before theforeman/foreman#10555 this wasn't a problem, the registration part worked and the fact that the second curl call failed was (silently) ignored. Fix the `Host` header sent to the API to use `quadlet.example.com` and thus generate the right command.
ekohl
reviewed
Sep 11, 2025
ekohl
approved these changes
Sep 11, 2025
ekohl
left a comment
ekohl
left a comment
Member
There was a problem hiding this comment.
I'm ok leaving it to later because this is already an improvement, but just raising a thought inline.
| @pytest.fixture(scope="module") | ||
| def certificates(pytestconfig): | ||
| def server_hostname(): | ||
| return 'quadlet.example.com' |
Member
There was a problem hiding this comment.
We also have the server part which calls paramiko://quadlet:
Lines 26 to 28 in 55fa1d2
That part also has the quadlet name. Can we somehow extract quadlet.example.com from the get_host call?
Member
Author
There was a problem hiding this comment.
I'll think about that part tomorrow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.