Improve Debian 13 support: hammer, IPA auth, bug fixes#427
Open
jakduch wants to merge 6 commits intotheforeman:debianfrom
Open
Improve Debian 13 support: hammer, IPA auth, bug fixes#427jakduch wants to merge 6 commits intotheforeman:debianfrom
jakduch wants to merge 6 commits intotheforeman:debianfrom
Conversation
The httpd_conf_path variable already contains the conf.d directory (e.g. /etc/httpd/conf.d on RedHat, /etc/apache2/conf-enabled on Debian), so the extra conf.d/ segment resulted in an invalid path like /etc/httpd/conf.d/conf.d/05-foreman.d/*.conf. The SSL vhost template was already correct.
- Use OS-specific package names for IPA Apache modules (mod_* on RedHat, libapache2-mod-* on Debian) - On RedHat: load modules via conf files in conf.modules.d - On Debian: enable modules via apache2_module (a2enmod) - Add httpd_ipa_packages and httpd_ipa_load_modules to both RedHat.yaml and Debian.yaml vars
Add OS-specific vars files for hammer role to use correct package naming conventions (hammer-cli-plugin-* on RedHat, ruby-hammer-cli-* on Debian). Load OS vars via include_vars and remove hardcoded package name pattern from defaults.
Without configuring the Foreman apt repository, no Foreman packages (including hammer-cli) can be installed on Debian. Use the existing theforeman.operations.foreman_repositories role which already supports Debian.
- Fix spurious space in httpd_conf_path variable expansion - On RedHat: remove module conf files from conf.modules.d - On Debian: disable modules via apache2_module (a2dismod) - Use httpd_ipa_load_modules flag to select correct method
With OS-specific package names now defined in hammer vars files, hammer should be installable on Debian. Remove the centos-only condition from the CI workflow.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on top of the Debian 13 work in #235, this adds:
Bug fixes:
Debian adaptations: