Pulp import export support by aidenfine · Pull Request #455 · theforeman/foremanctl

aidenfine · 2026-04-17T15:28:11Z

Why are you introducing these changes? (Problem description, related links)

Add pulp content import/export arguments.

What are the changes introduced in this pull request?

You can pass in multiple args of either --content-import-path or --content-export-path as many times as you want, since these will be appended as a list. These folders will be automatically created.

How to test this pull request

pytest tests/pulp_test.py

Can also manually test these steps.

# create env
./foremanctl deploy --foreman-initial-admin-password=changeme --tuning development --content-import-path /mycontentpath/import --content-export-path /mycontentpath/export --content-export-path /mycontentpath/export2

# ssh 
vagrant ssh quadlet

# verify imports (should see a list with exported/imported paths)
sudo podman exec pulp-api pulpcore-manager shell -c "from django.conf import settings; print(settings.ALLOWED_IMPORT_PATHS)"

# exports
sudo podman exec pulp-api pulpcore-manager shell -c "from django.conf import settings; print(settings.ALLOWED_EXPORT_PATHS)"

ehelms · 2026-04-17T15:52:17Z

    action: append_unique
    type: FQDN
    parameter: --certificate-cname
+  pulp_extra_import_paths:


The user doesn't care that it's Pulp right? How about:

Suggested change

pulp_extra_import_paths:

content_extra_import_paths:

What makes them "extra" ?

Good point. I used extra because users can add extra or additional import/export paths. Would you prefer something other than extra?

I'm trying to remember, I think the installer uses this "extra" terminology.

Ahh, it uses additional. So there are the "you can use these out of the box paths" and then there are "user has some setup, they want to use these paths and accept the requirements to make this work".

ehelms · 2026-04-17T15:54:15Z

+- `pulp_database_ssl_mode`: Database SSL mode (default: `disabled`)
+- `pulp_database_ssl_ca`: Path to the database SSL CA certificate on the control node (default: empty)
+
+Usage Inside foremanctl


I am not sure this detail makes sense at this level. I'd rather see a section in the deployment document around content or add a content document.

ehelms · 2026-04-17T15:55:12Z

+
+Variables
+---------
+- `pulp_container_image`: Container image to use for Pulp (default: `quay.io/foreman/pulp`)


I am wary of storing defaults in the documentation here. The code can show those and reduce our overhead.

I was hoping someone would comment on the docs. I tried to follow similar patterns from the roles/hammer/README.md. I also feel this is kinda an info dump but wanted to get opinions on it. I don't mind removing this doc from the PR if it makes more sense not to have this

I like the having of a README. I can see now that this is following roughly the outline from the hammer role. I think as long as we are consistent in the structure then keep it.

And we should define that roughly in https://github.com/theforeman/foremanctl/blob/master/docs/developer/playbooks-and-roles.md#shared-metadata-fragments

You do not have to do that here in this PR. I am noting this as a reminder.

ehelms · 2026-04-17T15:55:35Z

+Pulp Role
+=========
+
+Deploys and manages [Pulp](https://pulpproject.org/) as Podman containers.


Suggested change

Deploys and manages [Pulp](https://pulpproject.org/) as Podman containers.

Deploys and manages [Pulp](https://pulpproject.org/) as Podman quadlets.

ehelms · 2026-04-17T15:56:11Z

+    - imports
+    - exports
+
+- name: Create extra import directories


I assume these would have to be mounted into the container?

Yeah I didn't think about that, I will add this

sjha4 · 2026-04-17T15:56:56Z

+  PULP_ALLOWED_IMPORT_PATHS: >-
+    {{ pulp_default_import_path + pulp_extra_import_paths }}
+  PULP_ALLOWED_EXPORT_PATHS: >-
+    {{ pulp_default_export_path + pulp_extra_export_paths }}


Locally I have this:
PULP_ALLOWED_IMPORT_PATHS: >-
['/var/lib/pulp/sync_imports', '/var/lib/pulp/imports']
PULP_ALLOWED_EXPORT_PATHS: >-
['/var/lib/pulp/exports']

These would be the default paths..

ehelms · 2026-04-17T15:57:28Z


 pulp_enable_analytics: false

+pulp_default_import_path:


This says import_path but it's an array.
I wonder can we have a single variable for import and one for export, and they are just lists that appended to?

I think this is a good idea. So instead of 4 variables (2 default, 2 lists to hold user passed values). We could just have 2 lists both by default containing the default path and just append user passed values to these lists.

Am I understanding this correctly?

ianballou · 2026-04-17T16:23:46Z

Can we make these import/export arguments also available via forge deploy-dev ?

ehelms · 2026-04-17T16:28:13Z

Can we make these import/export arguments also available via forge deploy-dev ?

Consider this method for defining them -- https://github.com/theforeman/foremanctl/blob/master/docs/developer/playbooks-and-roles.md#shared-metadata-fragments

ianballou · 2026-04-17T17:36:08Z

I just tried this out, seeing the following in my pulp-api service definition:

Environment='PULP_ALLOWED_IMPORT_PATHS=['"'"'/var/lib/pulp/imports'"'"', '"'"'/var/lib/pulp/my_imports'"'"', '"'"'/var/lib/pulp/my_exports'"'"', '"'"'/var/lib/pulp/exports'"'"']'
Environment='PULP_ALLOWED_EXPORT_PATHS=['"'"'/var/lib/pulp/exports'"'"', '"'"'/var/lib/pulp/my_exports'"'"']'

So far so good, assuming the escaping is correct. And yes, I like to be able to import from my export directory.

ianballou · 2026-04-17T17:39:05Z

Export and import worked! I was able to generate /var/lib/pulp/exports/Default_Organization/Export-Zoo-1/1.0/2026-04-17T17-37-04-00-00/ and import it back into another repository. Perfect.

aidenfine · 2026-04-17T18:31:04Z

@ehelms I am not too sure on how to make sure the created import and export directories are mounted into the container. Can you point me into the right direction. Maybe somewhere in the code we handle a similar workflow

ehelms · 2026-04-17T20:01:11Z

@ehelms I am not too sure on how to make sure the created import and export directories are mounted into the container. Can you point me into the right direction. Maybe somewhere in the code we handle a similar workflow

You'll need to do something like this -- https://github.com/theforeman/foremanctl/blob/master/src/roles/pulp/tasks/main.yaml#L137

ehelms · 2026-04-24T19:23:35Z


 pulp_enable_analytics: false

+# pulp import/export paths


This is redundant.

ehelms · 2026-04-24T19:25:42Z

+pulp_volumes: >-
+  {{
+    ['/var/lib/pulp:/var/lib/pulp'] +
+    (pulp_import_paths | map('regex_replace', '^(.+)$', '\1:\1') | list) +


What are these regexs doing?

lets take one item from pulp_import_paths and call it string1, so string1="/foo/bar"
this regex turns string1 into the same format as the line above. ('/var/lib/pulp:/var/lib/pulp').

So after string1 runs through regex, we get "/foo/bar:/foo:bar"

ehelms · 2026-04-24T19:26:59Z

  foreman_development_github_username:
    help: GitHub username to add as additional remote for git checkouts
    action: store
+  pulp_import_paths:


You could define these in a file like https://github.com/theforeman/foremanctl/blob/master/src/playbooks/_database_connection/metadata.obsah.yaml and then include that file in both deploy and deploy-dev.

aidenfine added 2 commits April 17, 2026 09:50

Add pulp import/export defaults and custom paths

8c7ddb7

Use pulp ENV names

090e0ad

pr-processor Bot added the Not yet reviewed label Apr 17, 2026

aidenfine changed the title ~~Sat-44059 pulp import export support~~ Pulp import export support Apr 17, 2026

add pulp role docs

52092e3

ehelms reviewed Apr 17, 2026

View reviewed changes

pr-processor Bot removed the Not yet reviewed label Apr 17, 2026

ehelms reviewed Apr 17, 2026

View reviewed changes

sjha4 reviewed Apr 17, 2026

View reviewed changes

ehelms reviewed Apr 17, 2026

View reviewed changes

aidenfine added 3 commits April 17, 2026 14:11

Merge user defined variables and default variables into one

27c6311

Change user facing args to content-*

a1733c5

add import/export args to deploy-dev

59a42fb

evgeni reviewed Apr 21, 2026

View reviewed changes

Comment thread src/roles/pulp/defaults/main.yaml

mount file paths and improve tests to verify paths are volume mounts

4ffabc2

aidenfine requested review from ehelms and evgeni April 24, 2026 18:03

ehelms reviewed Apr 24, 2026

View reviewed changes

	Deploys and manages [Pulp](https://pulpproject.org/) as Podman containers.
	Deploys and manages [Pulp](https://pulpproject.org/) as Podman quadlets.

Conversation

aidenfine commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why are you introducing these changes? (Problem description, related links)

What are the changes introduced in this pull request?

How to test this pull request

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aidenfine Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ianballou commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ehelms commented Apr 17, 2026

Uh oh!

ianballou commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ianballou commented Apr 17, 2026

Uh oh!

aidenfine commented Apr 17, 2026

Uh oh!

ehelms commented Apr 17, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aidenfine commented Apr 17, 2026 •

edited

Loading

aidenfine Apr 17, 2026 •

edited

Loading

ianballou commented Apr 17, 2026 •

edited

Loading

ianballou commented Apr 17, 2026 •

edited

Loading