configure hosts for ActionDispatch::HostAuthorization middleware#471
Draft
configure hosts for ActionDispatch::HostAuthorization middleware#471
Conversation
evgeni
commented
Apr 23, 2026
| --- | ||
| :foreman_url: {{ foreman_url }} | ||
|
|
||
| :hosts: |
Member
Author
There was a problem hiding this comment.
which makes me wonder, right now the parameter is --certificate-cname, but in reality this is not about certificates (only) [and we already identified that "cname" is wtong]
so should the parameter be something like --alternative-server-name
Member
There was a problem hiding this comment.
I agree with the over-all principle here in a parameter that is above but feeds into certificates. Since naming is fun, other ideas:
--server-alias (how Apache defines it)
--server-name-alias
--subject-alternative-name (from certificates but still tied to that concept)
evgeni
force-pushed
the
host-header-check
branch
from
0445457 to
9cf9ade
Compare
Member
Author
|
the tests are failing because we use the IP address for smoker (as it runs on a system that has no working DNS towards the deployed foreman) and that's not allowed now. possible solutions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
moar secure
What are the changes introduced in this pull request?
configure
hostsso that Rails can reject HTTP requests with invalidHostheadrsHow to test this pull request
test in the patch
Checklist