Skip to content

disable pulpcore analytics#65

Merged
evgeni merged 1 commit intotheforeman:masterfrom
archanaserver:disable-pulpcore-analytics
Feb 18, 2025
Merged

disable pulpcore analytics#65
evgeni merged 1 commit intotheforeman:masterfrom
archanaserver:disable-pulpcore-analytics

Conversation

@archanaserver
Copy link
Copy Markdown
Contributor

@archanaserver archanaserver commented Jan 7, 2025

Fixes #58

@archanaserver archanaserver marked this pull request as draft January 7, 2025 05:18
@archanaserver archanaserver force-pushed the disable-pulpcore-analytics branch from 0c691b8 to 88b37f7 Compare January 7, 2025 05:22
@archanaserver archanaserver marked this pull request as ready for review January 7, 2025 07:36
@archanaserver
Copy link
Copy Markdown
Contributor Author

Can anyone help with, how can I ensure here that the setting I'm trying to make is updated in our setting.py file? Any thoughts? Also does it require any other config update?

@ekohl ekohl linked an issue Jan 9, 2025 that may be closed by this pull request
@ekohl
Copy link
Copy Markdown
Member

ekohl commented Jan 9, 2025

#58

If you use Fixes #58 it will automatically link up the issue and close it when this is merged.

@archanaserver
Copy link
Copy Markdown
Contributor Author

@ekohl @ehelms can you help me understand what is this ansible lint failure here?
https://github.com/theforeman/foreman-quadlet/actions/runs/13130019605/job/36633198924?pr=65

@ehelms
Copy link
Copy Markdown
Member

ehelms commented Feb 4, 2025

Trying to fix that over here -- #74

@archanaserver archanaserver force-pushed the disable-pulpcore-analytics branch from 435d243 to f30d2fc Compare February 5, 2025 08:04
@ehelms
Copy link
Copy Markdown
Member

ehelms commented Feb 7, 2025

Also, I am not sure why the tests are failing right now. This appears unrelated to your change.

@archanaserver archanaserver force-pushed the disable-pulpcore-analytics branch 2 times, most recently from 35e0326 to 8cbcd16 Compare February 17, 2025 14:50
@archanaserver archanaserver force-pushed the disable-pulpcore-analytics branch from 8cbcd16 to 96f01ae Compare February 17, 2025 16:04
@archanaserver
Copy link
Copy Markdown
Contributor Author

How the failure is coming from different test every time? Any idea, why this is failing? @ehelms @ekohl

@ekohl
Copy link
Copy Markdown
Member

ekohl commented Feb 17, 2025

That looks like a race condition:

Pending tasks detected in repositories of this content view. Please wait for the tasks: - http://quadlet.example.com/foreman_tasks/tasks/0c2d6155-ad28-4864-baa2-17b4c0120229 before publishing.

I suspect the sync action is returning a task that sometimes completes on time, sometimes it doesn't. That probably needs a wait_for_task, but I'm not that familiar with the content side.

@evgeni
Copy link
Copy Markdown
Member

evgeni commented Feb 18, 2025

I think it's a Katello-vs-new-Pulp issue.
In #79 I've pinned to 3.63 (which is what Katello uses right now) and it passes.

Copy link
Copy Markdown
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evgeni please verify my suggestion is correct and merge it :)

@evgeni evgeni force-pushed the disable-pulpcore-analytics branch from 96f01ae to 82c2fb9 Compare February 18, 2025 13:55
@evgeni evgeni force-pushed the disable-pulpcore-analytics branch from 82c2fb9 to dcee76b Compare February 18, 2025 13:58
@evgeni evgeni merged commit 7904384 into theforeman:master Feb 18, 2025
3 checks passed
@archanaserver archanaserver deleted the disable-pulpcore-analytics branch February 19, 2025 07:37
@ehelms ehelms added this to the 1.0 milestone Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Disable pulpcore analytics

4 participants