Deploy foreman-certs from source instead of unmerged PR COPR build#673
Open
ehelms wants to merge 1 commit into
Open
Deploy foreman-certs from source instead of unmerged PR COPR build#673ehelms wants to merge 1 commit into
ehelms wants to merge 1 commit into
Conversation
ehelms
force-pushed
the
mock-installer-from-nightly
branch
from
July 17, 2026 17:22
e1ca4ce to
b51b2a2
Compare
foreman-installer PR #935 adds foreman-certs but is not yet merged, so the mock-installer role was pinned to a COPR build of that PR. Deploy the binary and Kafo scenario config as role files instead, relying only on the nightly foreman-installer-katello package for puppet, modules, and kafo-export-params. Extract repository setup into a reusable role so mock-installer is self-contained and does not require forge setup-repositories to run first. Co-Authored-By: Claude <noreply@anthropic.com>
ehelms
force-pushed
the
mock-installer-from-nightly
branch
from
July 17, 2026 17:55
b51b2a2 to
66d0bec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
foreman-installer PR #935 adds the
foreman-certscommand but is not yet merged, so the mock-installer role was pinned to a COPR build of that PR. This is fragile — COPR builds are ephemeral and tied to a specific PR state. The binary and its Kafo scenario config can be deployed as role files instead, relying only on the nightlyforeman-installer-katellopackage for puppet, modules, andkafo-export-params.Additionally, repository setup was inlined in the
setup-repositoriesplaybook and not reusable, requiringforge setup-repositoriesto be run beforeforge mock-installer.theforeman/foreman-installer#935
What are the changes introduced in this pull request?
mock_foreman_installerfiles/foreman-certs,files/foreman-certs.yaml, andfiles/foreman-certs-answers.yamlto the role — equivalent to whatrake installproduces for theforeman-certsscenario in PR #935puppet-stringsinto Puppet's gem environment before runningforeman-certs(required bykafo-export-paramsfor parser cache generation)development/roles/setup_repositoriesand refactorsetup-repositories.yamlto delegate to itsetup_repositoriesas the first role inmock-installer.yamlsoforge mock-installeris self-containedHow to test this pull request
Steps to reproduce:
./forge mock-installeron a fresh VM without running./forge setup-repositoriesfirst/root/ssl-build//etc/foreman-installer/scenarios.d/contains the fixture files/usr/sbin/foreman-certsis present and executableChecklist