Add Registration smart proxy feature (SAT-44972)#675
Draft
jeremylenz wants to merge 3 commits into
Draft
Conversation
Implements host registration through the smart proxy with HTTPS-only support and Templates dependency. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add template_url to templates.yml to satisfy plugin validation requirements. Update registration test to verify feature state instead of hardcoded URL for better test portability. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
ehelms
reviewed
Jul 17, 2026
| --add-feature remote-execution \ | ||
| --add-feature bmc \ | ||
| --add-feature registration \ | ||
| --registration-url https://quadlet.example.com:8443 \ |
Member
There was a problem hiding this comment.
I don't think we should set this in our tests.
Contributor
Author
There was a problem hiding this comment.
Agreed — removed it. The parameter is optional and the test just verifies the feature is present and running.
The registration_url parameter is optional and doesn't need to be set in tests. The test already verifies the feature is present and running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are you introducing these changes? (Problem description, related links)
Adds the Registration smart proxy feature for foremanctl to support proxying host registration requests to Foreman (Jira ticket SAT-44972).
What are the changes introduced in this pull request?
--registration-urlparameter for custom registration endpoints (e.g. load balancers)foreman-proxy-contentflavor for standalone Capsule deploymentsNotes
templatesentry infeatures.yamland a basictemplates.yml.j2settings template to support the dependency. These will overlap with PR Add Templates feature to foreman-proxy #519 (Templates feature) — conflicts are additive and easy to resolve once that PR merges.How to test this pull request
Steps to reproduce:
cd src && ansible-lintto verify linting passes--add-feature registration --registration-url https://quadlet.example.com:8443registration_urlsetting is correctly exposed via/v2/featuresChecklist