Fixes #39446 - Reject non-PEM content in foreman-certificate-check#676
Open
Satellite-RedHat wants to merge 1 commit into
Open
Conversation
Add the same PEM-only validation used by katello-certs-check so custom certificates and CA bundles fail early during deploy. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
check-pem-contentfrom foreman-installer #1062 intoforeman-certificate-checkBEGIN/END CERTIFICATEblocks (for example PKCS#12 Bag Attributes or comment lines)Reference discussion:
theforeman/foreman-installer#1062 (comment)
Why
foreman-certificate-checkcould previously accept cert/CA files with non-PEM text between blocks. Those files can pass OpenSSL checks but fail later in production. Installer #1062 adds the same guard tokatello-certs-check; this change keeps the containerized install path aligned.Related:
Test cases added