Fix installation of non-develop katello-devel box#1708
Fix installation of non-develop katello-devel box#1708m-bucher wants to merge 3 commits intotheforeman:masterfrom
Conversation
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
dc5ef42 to
72edf9e
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
72edf9e to
3b1a619
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
3b1a619 to
b375a39
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
b375a39 to
6f0f931
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
6f0f931 to
7fd8004
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
7fd8004 to
543e287
Compare
roles/katello_devel/meta/main.yml
Outdated
| - "--katello-devel-extra-plugins theforeman/foreman_rh_cloud" | ||
| - "--katello-devel-extra-plugins theforeman/foreman_virt_who_configure" |
There was a problem hiding this comment.
Do we really always need this? This breaks the installation of a non-nightly version, because it always takes the latest version.
If we want to always install this (without making it optional), this would also need a possibility to configure the specific SCM-version.
There was a problem hiding this comment.
Probably also a question for @chris1984 , because you added this in #1783
I would rather have it in centos9-katello-devel sample definition (see diff), so one can opt-out 😁 .
There was a problem hiding this comment.
I am fine with that, we just added it since we were doing a lot of work with virt-who at the time and also now doing work with rh_cloud. Feel free to move it out @m-bucher where it can be opt-out if needed.
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
543e287 to
44e16f2
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
44e16f2 to
303fc04
Compare
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
This looks OK to me. Minor note about Debian 12 inline.
There was a problem hiding this comment.
This looks like an unrelated change. Mind separating that out?
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
303fc04 to
7896dd3
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
7896dd3 to
ab99baf
Compare
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
ab99baf to
9a69dfb
Compare
requires theforeman/puppet-katello_devel@e276ccb Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
m-bucher
force-pushed
the
fix_non-develop_branch
branch
from
9a69dfb to
d39044a
Compare
3 participants
The example probably does not work, since the mentioned fix to puppet-katello_devel is probably not available in the yum-repositories.
Requires theforeman/puppet-katello_devel@e276ccb