Skip to content

Remove oVirt installer option#1911

Merged
evgeni merged 1 commit into
theforeman:masterfrom
stejskalleos:ls/bye_ovirt
Jun 17, 2025
Merged

Remove oVirt installer option#1911
evgeni merged 1 commit into
theforeman:masterfrom
stejskalleos:ls/bye_ovirt

Conversation

@stejskalleos

Copy link
Copy Markdown
Contributor

No description provided.

@ekohl ekohl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 7ad1c93 we had version specific checks so we did enable it on older versions. I wonder if we should do that in the pipelines (not the luna_demo_environment.yml file) too. That way we install it on an older version and when we upgrade it to nightly we also verify the upgrade path. At least from a packaging perspective.

@evgeni

evgeni commented Jun 12, 2025

Copy link
Copy Markdown
Member

I thought about that too, but am not strictly convinced testing the upgrade would give us anything useful.

  • there is no ovirt-related data in the DB, so the migration would be noop anyway
  • packaging (at least debian), I tested as part of Remove oVirt [deb] foreman-packaging#12097 and don't see the pipeline being able to tell us more than that
  • inline jinja is awful, if we can avoid adding more of it…

So I'd be OK merging this as-is.

@stejskalleos

Copy link
Copy Markdown
Contributor Author

there is no ovirt-related data in the DB

Yes, the oVirt integration hasn't been working properly for quite some time, and there is probably nothing to migrate anyway.

@evgeni
evgeni merged commit 536af1c into theforeman:master Jun 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants