Remove oVirt installer option#1911
Merged
Merged
Conversation
ekohl
reviewed
Jun 12, 2025
ekohl
left a comment
Member
There was a problem hiding this comment.
In 7ad1c93 we had version specific checks so we did enable it on older versions. I wonder if we should do that in the pipelines (not the luna_demo_environment.yml file) too. That way we install it on an older version and when we upgrade it to nightly we also verify the upgrade path. At least from a packaging perspective.
Member
|
I thought about that too, but am not strictly convinced testing the upgrade would give us anything useful.
So I'd be OK merging this as-is. |
Contributor
Author
Yes, the oVirt integration hasn't been working properly for quite some time, and there is probably nothing to migrate anyway. |
evgeni
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.