Determine color usage dynamically#296
Draft
ekohl wants to merge 1 commit into
Draft
Conversation
ekohl
force-pushed
the
determine-colors-dynamically
branch
from
September 21, 2023 15:17
2b7ba49 to
f633d04
Compare
ehelms
reviewed
Sep 21, 2023
ekohl
force-pushed
the
determine-colors-dynamically
branch
from
September 21, 2023 17:44
f633d04 to
f09afdc
Compare
This changes the color usage to be determined dynamically. Prior to this the config was always read. That meant that if the scenario was ever written to disk (using save_configuration), it stored the value of colors_possible? and uses that indefinitely. After this change, the value of colors will remain nil (determined at runtime) until the user uses --[no-]colors, which is then persisted.
ekohl
force-pushed
the
determine-colors-dynamically
branch
from
July 3, 2025 11:41
f09afdc to
5c7e9f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the color usage to be determined dynamically. Prior to this the config was always read. That meant that if the scenario was ever written to disk (using save_configuration), it stored the value of colors_possible? and uses that indefinitely.
After this change, the value of colors will remain nil (determined at runtime) until the user uses --[no-]colors, which is then persisted.