Add parameter to control listen-on#273
Merged
ekohl merged 1 commit intotheforeman:masterfrom Feb 14, 2025
Merged
Conversation
ekohl
reviewed
Feb 14, 2025
manifests/init.pp
Outdated
| Variant[Enum['unmanaged'], Stdlib::Absolutepath] $defaultzonepath = $dns::params::defaultzonepath, | ||
| Optional[Enum['only', 'first']] $forward = undef, | ||
| Array[Dns::Forwarder] $forwarders = [], | ||
| Optional[Variant[String, Boolean]] $listen_on = undef, |
Member
There was a problem hiding this comment.
Why a boolean instead of just an optional string?
Suggested change
| Optional[Variant[String, Boolean]] $listen_on = undef, | |
| Optional[String] $listen_on = undef, |
Is it for consistency with $listen_on_v6? I'm not sure we need to care about that too much.
Contributor
Author
There was a problem hiding this comment.
It is for consistency with listen_on_v6 but I agree we can probably ignore it. Let me update the change.
... so that both listen-on and listen-on-v6 can be managed by the native parameters.
ekohl
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... so that both listen-on and listen-on-v6 can be managed by the native parameters.