-
Notifications
You must be signed in to change notification settings - Fork 128
Manager certificate permissions if manage_certificates true #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ad9caed
to
b71baf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also have some code to manage Puppet certificates. I'm not entirely sure if this will conflict, but want you to be aware of it:
puppet-foreman_proxy/manifests/config.pp
Lines 114 to 135 in af23995
unless $foreman_proxy::puppetca or $foreman_proxy::puppet { | |
# The puppet-agent doesn't create a puppet user and group | |
# but the foreman proxy still needs to be able to read the agent's private key | |
if $foreman_proxy::manage_puppet_group and $foreman_proxy::ssl { | |
if !defined(Group[$foreman_proxy::puppet_group]) { | |
group { $foreman_proxy::puppet_group: | |
ensure => 'present', | |
before => User[$foreman_proxy::user], | |
} | |
} | |
$ssl_dirs_and_files = [ | |
$foreman_proxy::ssldir, | |
"${foreman_proxy::ssldir}/private_keys", | |
$foreman_proxy::ssl_ca, | |
$foreman_proxy::ssl_key, | |
$foreman_proxy::ssl_cert, | |
] | |
file { $ssl_dirs_and_files: | |
group => $foreman_proxy::puppet_group, | |
} | |
} | |
} |
50b00c6
to
3dc3c6d
Compare
I'm stuck on why the tests are not seeing the resource present. |
Use |
Signed-off-by: Eric D. Helms <[email protected]>
Reviving an old PR with fresh updates. The idea behind this is at the users choice, the module can manage the certificates for the smart-proxy. When true, this will copy certificates provided into a known and controlled location, ensuring the right owner and group are set on them such that the smart-proxy can operate as intended. This is borrowed from, and can replace, puppet-certs implementation and help prevent an ordering problem with certificate generation and deployment. And this can provide a native way to indicate when a service restart is needed.