Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark compatible with puppetlabs/stdlib 9.x #77

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 8, 2023

No description provided.

Copy link

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evgeni evgeni closed this Mar 21, 2025
@evgeni evgeni reopened this Mar 21, 2025
@evgeni
Copy link
Member

evgeni commented Mar 21, 2025

Hmm.

Should

break if data.nil? || data.empty?
be return nil?

@ekohl
Copy link
Member Author

ekohl commented Mar 21, 2025

I ran into that in the other PR as well: #82 (comment). I've updated that PR so I think tests should pass.

@ekohl ekohl force-pushed the compat-with-stdlib-9 branch from 698aaaa to b513a81 Compare March 21, 2025 13:30
@ekohl ekohl merged commit 7482c69 into theforeman:master Mar 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants