Merged
Conversation
ekohl
approved these changes
Apr 17, 2025
Member
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
I don't have a strong opinion on this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason this seems to depend on db being migrated, currently the webpack compile step fails like this https://gist.github.com/lumarel/3d04de883cc14deb7f5cff12b0ea2e30 .
Afaik it shouldn't be necessary anymore, if foreman is started with the provided procfile, webpack should be watching the directory and compiling assets on the fly.
An alternative fix would be to change the ordering.