Skip to content

add packit#341

Merged
evgeni merged 1 commit into
masterfrom
packit
Dec 17, 2024
Merged

add packit#341
evgeni merged 1 commit into
masterfrom
packit

Conversation

@evgeni

@evgeni evgeni commented May 13, 2024

Copy link
Copy Markdown
Member

No description provided.

@theforeman theforeman deleted a comment from packit-as-a-service Bot May 13, 2024
@theforeman theforeman deleted a comment from packit-as-a-service Bot May 13, 2024
@evgeni
evgeni force-pushed the packit branch 4 times, most recently from f3d0898 to eb4e714 Compare May 13, 2024 10:17
@theforeman theforeman deleted a comment from packit-as-a-service Bot May 13, 2024
@evgeni
evgeni marked this pull request as draft May 13, 2024 11:23
@ehelms

ehelms commented May 13, 2024

Copy link
Copy Markdown
Member

Cool idea!

@ekohl

ekohl commented May 13, 2024

Copy link
Copy Markdown
Member

As I said on Matrix, if we go this route then I think we should prioritize theforeman/kafo#343 because it really cuts down on the CPU time spent by a lot. Previously it wasn't as big of an issue, but with packit it gets bigger.

@evgeni

evgeni commented Dec 16, 2024

Copy link
Copy Markdown
Member Author

note from team discussion: can packit be triggered on demand (comment or so), instead of always building

@evgeni
evgeni marked this pull request as ready for review December 16, 2024 13:42
Comment thread .packit.yaml
jobs:
- job: copr_build
trigger: pull_request
manual_trigger: true

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekohl @ehelms a tiny bolean making it all just work like we want :)

@evgeni

evgeni commented Dec 16, 2024

Copy link
Copy Markdown
Member Author

/packit build

@ekohl ekohl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, but otherwise 👍

Comment thread .packit.yaml Outdated
@evgeni
evgeni enabled auto-merge (rebase) December 17, 2024 17:28
@evgeni
evgeni merged commit 8875517 into master Dec 17, 2024
@evgeni
evgeni deleted the packit branch December 17, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants